Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exact ends #76

Merged
merged 2 commits into from Nov 20, 2019
Merged

Exact ends #76

merged 2 commits into from Nov 20, 2019

Conversation

Fil
Copy link
Member

@Fil Fil commented Nov 19, 2019

solves #73

@Fil
tests for exact ends
79d3df8 
numbers, dates, round, arrays
@Fil
exact ends
4b9001b
@Fil Fil requested a review from mbostock November 19, 2019 17:54
mbostock
mbostock approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you.

@mbostock mbostock mentioned this pull request Nov 19, 2019
Closed
@Fil Fil merged commit c3473cf into master Nov 20, 2019
@Fil Fil deleted the exact-ends branch November 20, 2019 21:01
@snyk-bot snyk-bot mentioned this pull request Jul 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock mbostock approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Fil @mbostock