Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid negative duration in interpolateZoom #102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid negative duration in interpolateZoom #102

wants to merge 1 commit into from

Conversation

jjhembd
Copy link

@jjhembd jjhembd commented Mar 4, 2022

See #101.

It's a simple change. I'm not aware of any case where allowing a negative duration would be useful—let me know if I'm wrong.

Fil
Fil approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fil Fil Fil approved these changes

@mbostock mbostock mbostock approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jjhembd @Fil @mbostock