Adopt type = module. #112
Merged
Adopt type = module. #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I investigated using @small-tech/esm-tape-runner and Tape, and it worked, but I like the experience and design of Mocha better, and I suspect it is now better supported. Probably going to go ahead with this PR, though I think I need to add an engines restriction to the package.json for either Node ≥12 or ≥14. |
|
@Fil Did you want to take a look at this? If you’re happy with this approach we can start applying it to the other D3 repos. |
Fil
added a commit
to Fil/attitude
that referenced
this pull request
Apr 24, 2021
following d3/d3-format#112
Merged
Fil
added a commit
to d3/versor
that referenced
this pull request
May 29, 2021
* adopt type="module" * modernize tooling * change default branch to main * license ISC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a “trial run” for adopting type: "module" throughout D3, per d3/d3#3469. Summary:
Rewriting all the tests is the most tedious part, but on the bright side, it’s an excuse to update them to modern ES syntax.