New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syntax was breaking our app build #215
Conversation
yarn run v1.22.10 ✓ ascending(a, b) returns a negative number if a < b 469 passing (123ms) |
If your parser won’t accept valid syntax as input, you should fix your parser rather than the input. |
@mbostock while I agree in principle, there's quite a few people struggling to get this working where the tooling is outside of our control (e.g. if you're within a create-react-app scenario). Seems that a lot of people are monkey patching to this suggested implementation. Is there any chance you'd reconsider to make it easier for a whole bunch of developers? |
@IPWright83 No. I’m not going to take on additional maintenance burden to workaround bugs in another toolchain. This should be fixed in Babel, for the benefit of everyone that uses it, not here. |
Related #147 babel/babel#7235 babel/babel#7234 |
Thanks @mbostock, I thought it worth at least asking, but totally get your stance. There's more linked issues than I've seen so I'll trawl through those later and see if I can find a better fix/upgrade something that'll sort it out. |
Hello, this function syntax makes our app crash. This fix is purely syntactic and fixes the problem.
Please check: https://github.com/FormidableLabs/victory-native/issues/653
Thanks for your consideration,
Thomas Zimmermann