Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow readonly arrays in JSON schema #472

Merged
merged 3 commits into from Oct 22, 2020
Merged

feat: allow readonly arrays in JSON schema #472

merged 3 commits into from Oct 22, 2020

Conversation

cyrilletuzi
Copy link
Owner

Given how JSON schema works, it is better to set them as const:

this.storage.get('name', { type: 'string' } as const);

But before v11, it was not possible when the JSON schema was using properties of array type (enum, items, required). This is now fixed, and is a first step toward auto-inferring the type from the JSON schema in all scenarios (#463).

Fixes #470

@cyrilletuzi cyrilletuzi merged commit 6336f5d into v11 Oct 22, 2020
@cyrilletuzi cyrilletuzi deleted the readonly branch October 22, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant