Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump lib/pq from 1.10.4 to 1.10.7 #295

Merged
merged 1 commit into from Apr 3, 2023

Conversation

aletournel
Copy link
Contributor

Hi @cyrilgdn ,

First, thanks for implementing this Terraform provider for PostgreSQL.

So here is a little bit of context first: at my company, we use a proxy to connect to our PostgreSQL servers and use the host in SNI to route the requests to the correct PostgreSQL server.

Unfortunately, the pq lib in version 1.10.4 doesn't specify a host when using SNI. But they did a fix six months ago for that (see lib/pq#1088) and released it in the 1.10.7 version. So I forked the provider, made this change and tested it on our deployment pipeline. It worked and made communication with the PostgreSQL servers through the proxy possible.

So this is why I created this PR to update pq lib to 1.10.7 from 1.10.4, and it would be fantastic if you could approve it so we can use your provider and not the fork I did.

Thanks in advance, and thanks again for all your work on this provider

@aletournel aletournel changed the title feat: update pq lib to 1.10.7 feat: Bump lib/pq from 1.10.4 to 1.10.7 Mar 31, 2023
Copy link
Owner

@cyrilgdn cyrilgdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the (well explained) PR 👍

@cyrilgdn cyrilgdn merged commit c34742d into cyrilgdn:master Apr 3, 2023
5 checks passed
@aletournel aletournel deleted the update-pq-lib-to-1-10-7 branch April 3, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants