Resolve sporadic failures in example-start running multiple servers #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Dec 10, 2022
|
Thanks @MikeMcC399! The action version bumps are handled in this PR. Let me try to get that merged today so you can rebase master and this will be even smaller. |
That certainly makes sense, especially to have a clean history. I'll watch for the merge of #644 and then rebase. Also it would be good to get the documentation to refer to v5 of GHA, although there is not much difference between v4 and v5 at the moment, they will diverge as time goes on. |
This comment was marked as outdated.
This comment was marked as outdated.
Bump actions/checkout@v2 to v3 to mitigate Node.js 12 deprecation warning
MikeMcC399
force-pushed
the
fix/example-start
branch
from
ee428a5
to
e58632b
Compare
|
Thank you for the merge of your #644! Rebasing this PR was painless and as luck would have it all tests have passed! So it's over to you now. |
This was referenced Dec 12, 2022
jaffrepaul
approved these changes
Dec 14, 2022
|
🎉 This PR is included in version 5.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
kodiakhq bot
added a commit
to weareinreach/InReach
that referenced
this pull request
Dec 20, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/checkout](https://togithub.com/actions/checkout) | action | digest | `7dd9e2a` -> `755da8c` | | [chromaui/action](https://togithub.com/chromaui/action) | action | digest | `0ec8cd8` -> `2440d35` | | [cypress-io/github-action](https://togithub.com/cypress-io/github-action) | action | patch | `v5.0.0` -> `v5.0.2` | | [github/codeql-action](https://togithub.com/github/codeql-action) | action | digest | `a669cc5` -> `959cbb7` | | [tinkurlab/monorepo-pr-labeler-action](https://togithub.com/tinkurlab/monorepo-pr-labeler-action) | action | patch | `4.1.2` -> `4.1.3` | --- ### Release Notes <details> <summary>cypress-io/github-action</summary> ### [`v5.0.2`](https://togithub.com/cypress-io/github-action/releases/tag/v5.0.2) [Compare Source](https://togithub.com/cypress-io/github-action/compare/v5.0.1...v5.0.2) Numerous housekeeping updates to bring this action back up to speed. \*In combination with v5.0.1, which triggered without a new dist build. 👏 Special thanks to [@​MikeMcC399](https://togithub.com/MikeMcC399) for all the diligent work! 👏 **Fix Failed Tests** - [cypress-io/github-action#643 - [cypress-io/github-action#658 - [cypress-io/github-action#660 **Update Dependencies** - [cypress-io/github-action#644 - [cypress-io/github-action#650 **Resolve Warnings** - [cypress-io/github-action#651 - [cypress-io/github-action#666 - [cypress-io/github-action#670 - [cypress-io/github-action#675 **Docs/Example Updates** - [cypress-io/github-action#665 - [cypress-io/github-action#668 **Tooling Updates:** - [cypress-io/github-action#667 - [cypress-io/github-action#677 ### [`v5.0.1`](https://togithub.com/cypress-io/github-action/releases/tag/v5.0.1) [Compare Source](https://togithub.com/cypress-io/github-action/compare/v5.0.0...v5.0.1) ##### Bug Fixes - correct .gitignore for videos and screenshots ([89e59e5](https://togithub.com/cypress-io/github-action/commit/89e59e5cfc7760513fe9e9ce4c690345d94eb27a)) </details> <details> <summary>tinkurlab/monorepo-pr-labeler-action</summary> ### [`v4.1.3`](https://togithub.com/TinkurLab/monorepo-pr-labeler-action/releases/tag/4.1.3): Monorepo PR Labeler v4.1.3 [Compare Source](https://togithub.com/tinkurlab/monorepo-pr-labeler-action/compare/4.1.2...4.1.3) Changes include: Bug fix to ignore directories starting with a dot `.` but not directories that contain a dot `.`. According to the docs, this action should ignore mono repos that begin with a dot but it currently ignores also mono repo with a dot even if it is not the first character. Thanks to [@​MoLow](https://togithub.com/MoLow) for the fix! </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/weareinreach/InReach). PR-URL: #107 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #657 "CI: Sporadic failures in example-start running multiple servers".
It modifies the action .github/workflows/example-start.yml:
NO_UPDATE_CHECK= 1 andVerification
Check that jobs of https://github.com/cypress-io/github-action/actions/workflows/example-start.yml are now regularly succeeding.
Release
The commits are tagged with
test:which does not cause a release to be triggered. The PR only affects the CI runs ofgithub-action, not the executable part ofgithub-action.The commits should be automatically listed in the release notes when a later PR with
fix:,feat:orperf:commit tag is merged.