Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to use Node v18, remove v12 #637

Merged
merged 1 commit into from Dec 1, 2022
Merged

feat: upgrade to use Node v18, remove v12 #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/example-node-versions.yml
View file
Open in desktop
Expand Up @@ -13,18 +13,18 @@ jobs:
# let's make sure Cypress works on several versions of Node
strategy:
matrix:
node: [12, 14, 16]
name: E2E on Node v${{ matrix.node }}
node: [14, 16, 18]
name: Cypress v9 E2E on Node v${{ matrix.node }}
steps:
- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
- run: node -v
- run: npm -v

- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3

# Hmm, should we rebuild the "dist" before using the action?

Expand All @@ -39,18 +39,18 @@ jobs:
# let's make sure Cypress works on several versions of Node
strategy:
matrix:
node: [12, 14, 16]
name: E2E on Node v${{ matrix.node }}
node: [14, 16, 18]
name: Cypress v10 E2E on Node v${{ matrix.node }}
steps:
- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
- run: node -v
- run: npm -v

- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3

# Hmm, should we rebuild the "dist" before using the action?

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Expand Up @@ -9,13 +9,13 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
node: [12, 14, 16]
node: [14, 16, 18]
name: Test on Node v${{ matrix.node }}
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3
- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
- uses: bahmutov/npm-install@v1
Expand All @@ -33,7 +33,7 @@ jobs:
if: github.ref == 'refs/heads/master'
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3
- uses: bahmutov/npm-install@v1
# https://github.com/cycjimmy/semantic-release-action
- name: Semantic Release
Expand Down
28 changes: 14 additions & 14 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Expand Up @@ -45,8 +45,8 @@
"quote": "0.4.0"
},
"devDependencies": {
"@types/node": "16.11.35",
"@vercel/ncc": "0.33.1",
"@types/node": "18.11.9",
"@vercel/ncc": "0.34.0",
"husky": "7.0.4",
"markdown-link-check": "3.10.2",
"prettier": "2.6.2",
Expand Down