-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): update dependency electron to version 11.0.2 π #9222
Conversation
See the guidelines for reviewing dependency updates for info on how to review dependency update PRs. |
Test summary8726 β’ 0 β’ 118 β’ 3 β’ 3 Run details
View run in Cypress Dashboard β‘οΈ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Test failures are due to electron/electron#26443 - going to see if it is released by the end of the week, if not, we can probably work around this before 6.0.0 |
also can replace |
d5d581b
to
eb4be05
Compare
@@ -121,6 +121,9 @@ module.exports = { | |||
y: 'browserY', | |||
devTools: 'isBrowserDevToolsOpen', | |||
}, | |||
webPreferences: { | |||
sandbox: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we probably should've been running with sandbox: true
all along, now it has become necessary in order to match Chrome's error behavior to Electron's
@@ -135,6 +135,8 @@ export function defaults (options = {}) { | |||
partition: null, | |||
webSecurity: true, | |||
nodeIntegration: false, | |||
// TODO: enable contextIsolation for Cypress browser (default in Electron 12) | |||
contextIsolation: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setting this to true
for electron browser causes issues with errors
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User-facing changelog
This PR contains the following updates:
10.1.5
->11.0.2
Release Notes
electron/electron
v11.0.2
Compare Source
Release Notes for v11.0.2
Fixes
LC_ALL
environment variable getting changed in Electron. #β26551 (Also in 9, 10)CTFontDescriptorIsSystemUIFont
in MAS build. #β26574Other Changes
Unknown
v11.0.1
Compare Source
Release Notes for v11.0.1
Fixes
v11.0.0
Compare Source
Release Notes for v11.0.0
Stack Upgrades
Breaking Changes
BrowserView.{destroy, fromId, fromWebContents, getAllViews}
and theid
property ofBrowserView
. #β23578Features
Additions
system-context-menu
event to allow preventing and overriding the system context menu. #β25835webContents.forcefullyCrashRenderer()
to forcefully terminate a renderer process to assist with recovering a hung renderer. #β25756app.getApplicationInfoForProtocol()
API that returns detailed information about the app that handles a certain protocol. #β24112name
toapp.getAppMetrics()
output. #β24359utility-process-gone
event toapp
. #β24367visualEffectState
option to BrowserWindows to allow customization of vibrancy effect state on macOS. #β25083visibleOnFullScreen
option forsetVisibleOnAllWorkspaces
. #β24956worldSafeExecuteJavaScript
webPreference to ensure that the return values fromwebFrame.executeJavaScript
are world safe when context isolation is enabled. #β24114 (Also in 9, 10)currencyCode
field that Apple's StoreKit in-app-purchasing library provides but has not been added to theProduct
object thatinAppPurchase.getProducts
returns. #β25058Improvements
--interactive
flag. #β24204takeHeapSnapshot()
. #β26230systemPreferences.getMediaAccessStatus()
on Windows. #β24275 (Also in 8, 9, 10)disabled-by-default-v8.cpu_profiler
tracing category is enabled, cpu samples will now be collected from the main process as well as the renderer. #β24819Removed/Deprecated
BrowserView.{destroy, fromId, fromWebContents, getAllViews}
and theid
property ofBrowserView
. #β23578Fixes
async_hooks
stack would crash the renderer when throwing some errors in the renderer process. #β26424window.open
not accepting size values with "px" at the end. #β26334 (Also in 10)BrowserWindow
was resized. #β26320 (Also in 9, 10)BrowserViews
. #β26259 (Also in 9, 10)app.commandLine.appendSwitch('lang')
not changing app's locale. #β26226 (Also in 9, 10)contextIsolation
was enabled. #β25829 (Also in 10)dialog.showMessageBox
API. #β26099 (Also in 8, 9, 10)UNUserNotificationCenter
notification (via a native node module). #β25738 (Also in 9, 10)webSecurity: false
. #β25504 (Also in 9, 10)ready-to-show
event not emitted on some machines. #β25471 (Also in 10)app.importCertificate()
on Linux. #β25537 (Also in 9, 10)webContents.print()
if no default was set and no device name provided. #β25562 (Also in 9, 10)document.hasFocus
anddocument.activeElement
would be inconsistent upon showing a window that was initially created withshow: false
. #β25323dock.show
/hide
on macOS. #β25300 (Also in 8, 9, 10)isComposing
KeyboardEvent property. #β23971 (Also in 8, 9, 10)chrome://accessibility
access in Electron. #β24437chrome://media-internals
andchrome://webrtc-internals
pages not loading. #β24010 (Also in 8, 9, 10)powerMonitor
not emittingsuspend
/resume
events on some Windows machines. #β25076 (Also in 10)process.windowsStore
returning undefined in AppX packages. #β23785 (Also in 7.3, 8, 9, 10)hookWindowMessage
on Windows. #β24716 (Also in 9, 10)ipcRenderer
module after blink had released the context. Instead, a JS exception will be thrown. #β23917 (Also in 8, 9, 10)dialog.showCertificateTrustDialog
with noBrowserWindow
. #β24091 (Also in 7.3, 8, 9, 10)rmdir
andrmdirSync
work withoriginal-fs
in an asar context. #β23890 (Also in 8, 9, 10)shutdown
would be emitted both on app and system shutdown on macOS. #β24111 (Also in 8, 9, 10)webContents.print()
would sometimes hang with invalid settings. #β24476 (Also in 9, 10)window.location
properties would throw an error for windows opened withwindow.open
. #β23776 (Also in 8, 9, 10)withFileTypes
was not supported as an option tofs.readdir
orfs.readdirSync
under asar. #β24062 (Also in 8, 9, 10)--cpu-prof
,--heap-prof
, and related CLI flags. #β24528 (Also in 8, 9, 10)assert
module would throw in both the browser and renderer processes. #β24579globalShortcut
registration. #β23782 (Also in 8, 9, 10)--trace-sync-io
flag in Node.js. #β24529 (Also in 8, 9, 10)session.loadExtension
. #β25068 (Also in 10)--disable-color-correct-rendering
. #β23787 (Also in 8, 9, 10)hasUserGesture
argument. #β24396globalShortcut
. #β24145guid
parameter in Linux crash reports. #β24881 (Also in 9, 10)session
in webContents of type remote. #β23989 (Also in 9, 10)nativeImages
over remote when moving from the main process to the renderer process. #β23759 (Also in 7.3, 8, 9, 10)acceptLanguages
argument being ignored insession.setUserAgent()
. #β23944 (Also in 7.3, 8, 9, 10)uv_dlopen
. #β24659shell.showItemInFolder
uses theFileManager
DBUS API on Linux, only falling back toxdg-open
if that fails. #β25087WebSQLDatabase
in extension background pages. #β24798 (Also in 9, 10)End of Support for 8.x.y
Electron 8.x.y has reached end-of-support as per the project's support policy. Developers and applications are encouraged to upgrade to a newer version of Electron.
v10.1.6
Compare Source
Release Notes for v10.1.6
Fixes
LC_ALL
environment variable getting changed in Electron. #β26550 (Also in 9)window.open
not accepting size values with "px" at the end. #β26333 (Also in 11)BrowserViews
. #β26260 (Also in 9, 11)BrowserWindow
was resized. #β26321 (Also in 9, 11)app.commandLine.appendSwitch('lang')
not changing app's locale. #β26241 (Also in 9, 11)Other Changes
takeHeapSnapshot()
. #β262291100470
,1125337
. #β262091128657
. #β261961133983
. #β262031135018
. #β261931135857
. #β261901143772
. #β263991144489
. #β263961117258
. #β261991132111
. #β262061133527
. #β264111137608
. #β264081137630
. #β262121139398
. #β26405Renovate configuration
π Schedule: "before 3am on the first day of the month" in timezone America/New_York.
π¦ Automerge: Disabled by config. Please merge this manually once you are satisfied.
β»οΈ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
π Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.