fix: Remove default esModuleInterop option from ts-node and preprocessor #8143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was replaced by 1_typescript_support_spec.ts.js
|
@chrisbreiding Nice. I would love links to any docs PRs that are needed or notes you would add for the Migration Guide. The below was previously mentioned for the Migration guide
But providing an example of before / after would be great. |
14 tasks
bahmutov
reviewed
Aug 4, 2020
packages/server/test/support/fixtures/projects/ts-proj/cypress/integration/app_spec.ts
Outdated
Show resolved
Hide resolved
|
@jennifer-shehane Submitted documentation PR: cypress-io/cypress-documentation#3053 |
kuceb
suggested changes
Aug 7, 2020
packages/server/test/support/fixtures/projects/ts-proj/cypress/integration/app_spec.ts
Outdated
Show resolved
Hide resolved
kuceb
approved these changes
Aug 7, 2020
…ocessor beside it
brian-mann
changed the base branch from
tr-49-default-preprocessor-webpack
to
v5.0-release
…esmodule-interop-default # Conflicts: # packages/server/__snapshots__/1_typescript_spec_support_spec.ts.js # packages/server/package.json # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
esModuleInteropoption is no longer coerced totrue. If you need to utilizeesModuleInterop, set it in yourtsconfig.json.Additional details
How has the user experience changed?
PR Tasks
cypress-documentation? Add section to migration guide about esModuleInterop change cypress-documentation#3053type definitions?cypress.schema.json?