Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change default preprocessor to webpack #7982

Merged
merged 37 commits into from Aug 10, 2020
Merged
Show file tree
Hide file tree
Changes from 29 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
4ebe66c
make tests preprocessor agnostic
chrisbreiding Jul 14, 2020
26e6c87
update eslintignore
chrisbreiding Jul 14, 2020
a234881
put back deps needed for e2e test
chrisbreiding Jul 14, 2020
7a210b1
Merge branch 'develop' into tr-49-default-preprocessor-webpack
chrisbreiding Jul 15, 2020
3c1e99f
remove obselete snapshot
chrisbreiding Jul 15, 2020
a2b0356
switch from browserify to webpack preprocessor
chrisbreiding Jul 15, 2020
00f58bf
cmon github
chrisbreiding Jul 15, 2020
99e32b8
fix/update tests
chrisbreiding Jul 15, 2020
5475b2d
bump preprocessor and update snapshots
chrisbreiding Jul 16, 2020
facc6ef
update snapshots
chrisbreiding Jul 16, 2020
73db7c5
bump preprocessor to gain json support
chrisbreiding Jul 16, 2020
205b7ec
fix e2e tests with webpack-originated errors
chrisbreiding Jul 17, 2020
eefd82c
bump preprocessor version, fix node globals
chrisbreiding Jul 17, 2020
ee5c144
update snapshot
chrisbreiding Jul 17, 2020
265d305
remove support for ? in file path
chrisbreiding Jul 17, 2020
b0d755d
Merge branch 'develop' into tr-49-default-preprocessor-webpack
chrisbreiding Jul 17, 2020
6f1863b
bump preprocessor version
chrisbreiding Jul 20, 2020
9d8a8c3
bump preprocessor again
chrisbreiding Jul 20, 2020
ec71582
bump preprocessor
chrisbreiding Jul 20, 2020
155821a
Merge branch 'develop' into tr-49-default-preprocessor-webpack
chrisbreiding Jul 21, 2020
4e7840f
bump preprocessor
chrisbreiding Jul 21, 2020
e83571b
Merge branch 'develop' into tr-49-default-preprocessor-webpack
chrisbreiding Jul 21, 2020
a0bc387
update snapshots
chrisbreiding Jul 21, 2020
b943176
bump preprocessor version
chrisbreiding Jul 23, 2020
86530af
bump preprocessor, quiet the paths plugin
chrisbreiding Jul 23, 2020
b0404f3
Merge branch 'v5.0-release' into tr-49-default-preprocessor-webpack
chrisbreiding Jul 23, 2020
8c265ee
Merge branch 'v5.0-release' into tr-49-default-preprocessor-webpack
chrisbreiding Jul 23, 2020
d212b0a
add test verifying tsconfig paths work
chrisbreiding Jul 23, 2020
03bd4eb
Merge branch 'v5.0-release' into tr-49-default-preprocessor-webpack
chrisbreiding Jul 27, 2020
61f5099
Merge branch 'v5.0-release' into tr-49-default-preprocessor-webpack
chrisbreiding Aug 10, 2020
c54eaac
bump batteries-included preprocessor and install latest webpack prepr…
chrisbreiding Aug 10, 2020
f1bcfb9
update snapshots
chrisbreiding Aug 10, 2020
1ff1150
put back snapshot
chrisbreiding Aug 10, 2020
d6248a7
update snapshot
chrisbreiding Aug 10, 2020
cfe5395
update snapshot
chrisbreiding Aug 10, 2020
3837ccd
Merge branch 'v5.0-release' into tr-49-default-preprocessor-webpack
chrisbreiding Aug 10, 2020
80ee0f7
Merge branch 'v5.0-release' into tr-49-default-preprocessor-webpack
brian-mann Aug 10, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintignore
Expand Up @@ -26,7 +26,7 @@ packages/server/lib/scaffold/plugins/index.js
packages/server/lib/scaffold/support/index.js
packages/server/lib/scaffold/support/commands.js
packages/server/test/support/fixtures/projects/e2e/cypress/integration/stdout_exit_early_failing_spec.js
packages/server/test/support/fixtures/projects/e2e/cypress/integration/browserify_typescript_failing_spec.ts
packages/server/test/support/fixtures/projects/e2e/cypress/integration/typescript_failing_spec.ts

**/.projects
**/*.d.ts
Expand Down
40 changes: 39 additions & 1 deletion packages/server/__snapshots__/1_busted_support_file_spec.js
Expand Up @@ -21,7 +21,45 @@ Oops...we found an error preparing this test file:

The error was:

Error: Cannot find module './does/not/exist' from '/foo/bar/.projects/busted-support-file/cypress/support'
Error: Webpack Compilation Error
./cypress/support/index.js
Module not found: Error: Can't resolve './does/not/exist' in '/foo/bar/.projects/busted-support-file/cypress/support'
resolve './does/not/exist' in '/foo/bar/.projects/busted-support-file/cypress/support'
using description file: [..] (relative path: ./.projects/busted-support-file/cypress/support)
Field 'browser' doesn't contain a valid alias configuration
using description file: [..] (relative path: ./.projects/busted-support-file/cypress/support/does/not/exist)
no extension
Field 'browser' doesn't contain a valid alias configuration
/foo/bar/.projects/busted-support-file/cypress/support/does/not/exist doesn't exist
.js
Field 'browser' doesn't contain a valid alias configuration
/foo/bar/.projects/busted-support-file/cypress/support/does/not/exist.js doesn't exist
.json
Field 'browser' doesn't contain a valid alias configuration
/foo/bar/.projects/busted-support-file/cypress/support/does/not/exist.json doesn't exist
.jsx
Field 'browser' doesn't contain a valid alias configuration
/foo/bar/.projects/busted-support-file/cypress/support/does/not/exist.jsx doesn't exist
.coffee
Field 'browser' doesn't contain a valid alias configuration
/foo/bar/.projects/busted-support-file/cypress/support/does/not/exist.coffee doesn't exist
.ts
Field 'browser' doesn't contain a valid alias configuration
/foo/bar/.projects/busted-support-file/cypress/support/does/not/exist.ts doesn't exist
.tsx
Field 'browser' doesn't contain a valid alias configuration
/foo/bar/.projects/busted-support-file/cypress/support/does/not/exist.tsx doesn't exist
as directory
/foo/bar/.projects/busted-support-file/cypress/support/does/not/exist doesn't exist
[/foo/bar/.projects/busted-support-file/cypress/support/does/not/exist]
[/foo/bar/.projects/busted-support-file/cypress/support/does/not/exist.js]
[/foo/bar/.projects/busted-support-file/cypress/support/does/not/exist.json]
[/foo/bar/.projects/busted-support-file/cypress/support/does/not/exist.jsx]
[/foo/bar/.projects/busted-support-file/cypress/support/does/not/exist.coffee]
[/foo/bar/.projects/busted-support-file/cypress/support/does/not/exist.ts]
[/foo/bar/.projects/busted-support-file/cypress/support/does/not/exist.tsx]
@ ./cypress/support/index.js 3:0-27
@ multi ./cypress/support/index.js

This occurred while Cypress was compiling and bundling your test code. This is usually caused by:

Expand Down
@@ -1,4 +1,4 @@
exports['e2e browserify, babel, es2015 passes 1'] = `
exports['e2e es modules passes 1'] = `

====================================================================================================

Expand All @@ -7,14 +7,14 @@ exports['e2e browserify, babel, es2015 passes 1'] = `
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Cypress: 1.2.3 │
│ Browser: FooBrowser 88 │
│ Specs: 1 found (browserify_babel_es2015_passing_spec.coffee) │
│ Searched: cypress/integration/browserify_babel_es2015_passing_spec.coffee │
│ Specs: 1 found (es_modules_in_coffee_spec.coffee)
│ Searched: cypress/integration/es_modules_in_coffee_spec.coffee
└────────────────────────────────────────────────────────────────────────────────────────────────┘


────────────────────────────────────────────────────────────────────────────────────────────────────

Running: browserify_babel_es2015_passing_spec.coffee (1 of 1)
Running: es_modules_in_coffee_spec.coffee (1 of 1)


imports work
Expand All @@ -37,15 +37,15 @@ exports['e2e browserify, babel, es2015 passes 1'] = `
│ Screenshots: 0 │
│ Video: true │
│ Duration: X seconds │
│ Spec Ran: browserify_babel_es2015_passing_spec.coffee │
│ Spec Ran: es_modules_in_coffee_spec.coffee
└────────────────────────────────────────────────────────────────────────────────────────────────┘


(Video)

- Started processing: Compressing to 32 CRF
- Finished processing: /XXX/XXX/XXX/cypress/videos/browserify_babel_es2015_passing (X second)
_spec.coffee.mp4
- Finished processing: /XXX/XXX/XXX/cypress/videos/es_modules_in_coffee_spec.coffe (X second)
e.mp4


====================================================================================================
Expand All @@ -55,15 +55,14 @@ exports['e2e browserify, babel, es2015 passes 1'] = `

Spec Tests Passing Failing Pending Skipped
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ ✔ browserify_babel_es2015_passing_spe XX:XX 3 3 - - - │
│ c.coffee │
│ ✔ es_modules_in_coffee_spec.coffee XX:XX 3 3 - - - │
└────────────────────────────────────────────────────────────────────────────────────────────────┘
✔ All specs passed! XX:XX 3 3 - - -


`

exports['e2e browserify, babel, es2015 fails 1'] = `
exports['e2e es modules fails 1'] = `

====================================================================================================

Expand All @@ -72,26 +71,32 @@ exports['e2e browserify, babel, es2015 fails 1'] = `
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Cypress: 1.2.3 │
│ Browser: FooBrowser 88 │
│ Specs: 1 found (browserify_babel_es2015_failing_spec.js) │
│ Searched: cypress/integration/browserify_babel_es2015_failing_spec.js │
│ Specs: 1 found (es_module_import_failing_spec.js)
│ Searched: cypress/integration/es_module_import_failing_spec.js
└────────────────────────────────────────────────────────────────────────────────────────────────┘


────────────────────────────────────────────────────────────────────────────────────────────────────

Running: browserify_babel_es2015_failing_spec.js (1 of 1)
Running: es_module_import_failing_spec.js (1 of 1)

Oops...we found an error preparing this test file:

/foo/bar/.projects/e2e/cypress/integration/browserify_babel_es2015_failing_spec.js
/foo/bar/.projects/e2e/cypress/integration/es_module_import_failing_spec.js

The error was:

Error: Webpack Compilation Error
./lib/fail.js
Module build failed (from [..]):
SyntaxError: /foo/bar/.projects/e2e/lib/fail.js: Unexpected token (2:0)

1 | export default {
> 2 |
| ^ while parsing file: /foo/bar/.projects/e2e/lib/fail.js
| ^

@ ./cypress/integration/es_module_import_failing_spec.js 3:0-25
@ multi ./cypress/integration/es_module_import_failing_spec.js

This occurred while Cypress was compiling and bundling your test code. This is usually caused by:

Expand All @@ -111,15 +116,15 @@ Fix the error in your code and re-run your tests.
│ Screenshots: 0 │
│ Video: true │
│ Duration: X seconds │
│ Spec Ran: browserify_babel_es2015_failing_spec.js │
│ Spec Ran: es_module_import_failing_spec.js
└────────────────────────────────────────────────────────────────────────────────────────────────┘


(Video)

- Started processing: Compressing to 32 CRF
- Finished processing: /XXX/XXX/XXX/cypress/videos/browserify_babel_es2015_failing (X second)
_spec.js.mp4
- Finished processing: /XXX/XXX/XXX/cypress/videos/es_module_import_failing_spec.j (X second)
s.mp4


====================================================================================================
Expand All @@ -129,8 +134,7 @@ Fix the error in your code and re-run your tests.

Spec Tests Passing Failing Pending Skipped
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ ✖ browserify_babel_es2015_failing_spe XX:XX - - 1 - - │
│ c.js │
│ ✖ es_module_import_failing_spec.js XX:XX - - 1 - - │
└────────────────────────────────────────────────────────────────────────────────────────────────┘
✖ 1 of 1 failed (100%) XX:XX - - 1 - -

Expand Down