Update blob-util, remove @types/blog-util #7784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jennifer-shehane
commented
Jun 23, 2020
jennifer-shehane
commented
- Close Replace dep @types/blob-util (it's deprecated) #6001
…ns (#7746) Co-authored-by: Jessica Sachs <jess@jessicasachs.io>
* Add UTM parameters to Dashboard login buttons * Revert "Add UTM parameters to Dashboard login buttons" This reverts commit 568f12e. * Add UTM parameters to Dashboard login buttons * utmCode camel case Co-authored-by: Zach Bloomquist <github@chary.us> * Add desktop-gui integration tests for utm code * Add server unit tests for utm code Co-authored-by: Zach Bloomquist <github@chary.us>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
* Option to disable Cypress the verbose results to stdout --quiet mode to disable the verbose results to stdout but still use specified formatter * Update cli/schema/cypress.schema.json Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com> * Cypress module support for --quiet Cypress module support for --quiet * Apply suggestions from code review Co-authored-by: Zach Bloomquist <github@chary.us> * Address feedback Address feedback, thanks Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com> Co-authored-by: Zach Bloomquist <github@chary.us>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
I don't remember correctly. But I failed at the last attempt, because the API has been changed in blob-util 2.x. So, some codes and even documentation should be changed because of the breaking change. I'll check them out tomorrow. |
|
@sainthkh Thanks, I'm not sure what needs to be changed but wanted to get it started. We're planning a 5.0 release, so thought we could get this in. Feel free to commit or start a new PR if necessary. |
|
Closing in favor of #7795 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.