Skip to content

Electron 8.1.1 #6555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Mar 13, 2020
Merged

Electron 8.1.1 #6555

merged 22 commits into from
Mar 13, 2020

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Feb 25, 2020

User facing changelog

  • Upgraded Electron to 8.1.1. This bumps the bundled Chromium to 80.0.3987.141 and the bundled Node to 12.13.0.

Additional details

How has the user experience changed?

PR Tasks

  • [na] Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 25, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@flotwig flotwig changed the base branch from develop to chrome-80 February 25, 2020 18:41
@cypress
Copy link

cypress bot commented Feb 25, 2020



Test summary

6954 0 97 0


Run details

Project cypress
Status Passed
Commit 414655f
Started Mar 12, 2020 8:56 PM
Ended Mar 12, 2020 9:02 PM
Duration 06:39 💡
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig changed the base branch from chrome-80 to develop March 3, 2020 21:32
@flotwig flotwig changed the title [WIP] Electron 8 Electron 8.0.3 Mar 3, 2020
@flotwig flotwig changed the title Electron 8.0.3 Electron 8.1.0 Mar 6, 2020
@flotwig
Copy link
Contributor Author

flotwig commented Mar 9, 2020

Running into the weirdest bug with screenshots. If Electron is running in headless mode with video recording disabled, the first Page.captureScreenshot hangs here: https://circleci.com/gh/cypress-io/cypress/276226?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

A response is only received for the second Page.captureScreenshot, taken when the test fails.

Calling Page.startScreencast and Page.stopScreencast around the Page.captureScreenshot call only adds about a millisecond to execution time and works around this issue.

@flotwig flotwig changed the title Electron 8.1.0 Electron 8.1.1 Mar 10, 2020
@@ -263,10 +280,7 @@ module.exports = {
_enableDebugger (webContents) {
debug('debugger: enable Console and Network')

return Bluebird.join(
webContents.debugger.sendCommand('Console.enable'),
webContents.debugger.sendCommand('Network.enable'),
Copy link
Contributor Author

@flotwig flotwig Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Network.enable ended up not being necessary, and was probably causing a lot of unnecessary background traffic over the debugger 😬

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting

@flotwig flotwig requested review from a team, brian-mann and kuceb and removed request for a team March 11, 2020 16:16
@flotwig flotwig requested review from brian-mann and kuceb March 13, 2020 18:09
@flotwig flotwig merged commit 910ac6f into develop Mar 13, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 16, 2020

Released in 4.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.2.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 16, 2020
@flotwig flotwig deleted the electron-8 branch January 24, 2022 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants