Electron 8.1.1

[flotwig]

User facing changelog

• Upgraded Electron to 8.1.1. This bumps the bundled Chromium to 80.0.3987.141 and the bundled Node to 12.13.0.

Additional details

• this PR will unblock fixes for Cypress is unable to load site in v3.5.0 due to "Parse Error" #5602 🎉
• paint event is not firing, so video recording will fail until this is fixed: Paint event is not triggered electron/electron#22357 switched to recording via CDP instead: Use CDP to record video for Electron, record video in Electron… #6632
• added workaround for Page.captureScreenshot hanging when video is not recording: Electron 8.1.1 #6555 (comment)
• internal version of nock was upgraded to latest (12x.), 9.x had some issues with 12.13.0. this caused a few unit test snapshots to be updated.
• spec consistently fails in CI:

  cypress/packages/server/test/e2e/3_plugins_spec.js

  Lines 32 to 40 in 0105ca7

  	it('fails when there is an async error at the root', function () {
  	return e2e.exec(this, {
  	spec: 'app_spec.js',
  	project: pluginsRootAsyncError,
  	sanitizeScreenshotDimensions: true,
  	snapshot: true,
  	expectedExitCode: 1,
  	})
  	})

  • also fails locally, even in develop
  • known issue outside of this PR, @chrisbreiding is looking into it

How has the user experience changed?

PR Tasks

• [na] Have tests been added/updated?
• Has the original issue been tagged with a release in ZenHub?
• [na] Has a PR for user-facing changes been opened in cypress-documentation?
• [na] Have API changes been updated in the type definitions?
• [na] Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

• Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
• Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

• The feature/bugfix is self-documenting from within the product.
• The change provides the end user with a way to fix their problem (no dead ends).

Functionality

• The code works and performs its intended function with the correct logic.
• Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
• The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

• The code is readable (too many nested 'if's are a bad sign).
• Names used for variables, methods, etc, clearly describe their function.
• The code is easy to understood and there are relevant comments explaining.
• New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
• There are comments containing link(s) to the addressed issue (in tests and code).

Quality

• The change does not reimplement code.
• There's not a module from the ecosystem that should be used instead.
• There is no redundant or duplicate code.
• There are no irrelevant comments left in the code.
• Tests are testing the code’s intended functionality in the best way possible.

Internal

• The original issue has been tagged with a release in ZenHub.

[cypress]

---

Test summary

6954 • 0 • 97 • 0

---

Run details

Project	cypress
Status	Passed
Commit	414655f
Started	Mar 12, 2020 8:56 PM
Ended	Mar 12, 2020 9:02 PM
Duration	06:39 💡
OS	Linux Debian - 10.1
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[flotwig]

Running into the weirdest bug with screenshots. If Electron is running in headless mode with video recording disabled, the first Page.captureScreenshot hangs here: https://circleci.com/gh/cypress-io/cypress/276226?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

A response is only received for the second Page.captureScreenshot, taken when the test fails.

Calling Page.startScreencast and Page.stopScreencast around the Page.captureScreenshot call only adds about a millisecond to execution time and works around this issue.

[flotwig]

Network.enable ended up not being necessary, and was probably causing a lot of unnecessary background traffic over the debugger 😬

[brian-mann]

interesting

[cypress-bot]

Released in 4.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.2.0, please open a new issue.