Electron 8.1.1 #6555

flotwig · 2020-02-25T18:40:28Z

User facing changelog

Upgraded Electron to 8.1.1. This bumps the bundled Chromium to 80.0.3987.141 and the bundled Node to 12.13.0.

Additional details

this PR will unblock fixes for Cypress is unable to load site in v3.5.0 due to "Parse Error" #5602 🎉
paint event is not firing, ~~so video recording will fail until this is fixed:~~ Paint event is not triggered electron/electron#22357 switched to recording via CDP instead: Use CDP to record video for Electron, record video in Electron… #6632
added workaround for Page.captureScreenshot hanging when video is not recording: Electron 8.1.1 #6555 (comment)
internal version of nock was upgraded to latest (12x.), 9.x had some issues with 12.13.0. this caused a few unit test snapshots to be updated.

spec consistently fails in CI:

cypress/packages/server/test/e2e/3_plugins_spec.js

Lines 32 to 40 in 0105ca7

    
           it('fails when there is an async error at the root', function () { 
        
             return e2e.exec(this, { 
        
               spec: 'app_spec.js', 
        
               project: pluginsRootAsyncError, 
        
               sanitizeScreenshotDimensions: true, 
        
               snapshot: true, 
        
               expectedExitCode: 1, 
        
             }) 
        
           })

also fails locally, even in develop
known issue outside of this PR, @chrisbreiding is looking into it

How has the user experience changed?

PR Tasks

[na] Have tests been added/updated?
Has the original issue been tagged with a release in ZenHub?
[na] Has a PR for user-facing changes been opened in cypress-documentation?
[na] Have API changes been updated in the type definitions?
[na] Have new configuration options been added to the cypress.schema.json?

cypress-bot · 2020-02-25T18:40:30Z

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

The feature/bugfix is self-documenting from within the product.
The change provides the end user with a way to fix their problem (no dead ends).

Functionality

The code works and performs its intended function with the correct logic.
Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

The code is readable (too many nested 'if's are a bad sign).
Names used for variables, methods, etc, clearly describe their function.
The code is easy to understood and there are relevant comments explaining.
New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
There are comments containing link(s) to the addressed issue (in tests and code).

Quality

The change does not reimplement code.
There's not a module from the ecosystem that should be used instead.
There is no redundant or duplicate code.
There are no irrelevant comments left in the code.
Tests are testing the code’s intended functionality in the best way possible.

Internal

The original issue has been tagged with a release in ZenHub.

cypress · 2020-02-25T18:59:58Z

Test summary

6954 • 0 • 97 • 0

Run details


Project	cypress
Status	Passed
Commit	`414655f`
Started	Mar 12, 2020 8:56 PM
Ended	Mar 12, 2020 9:02 PM
Duration	06:39 💡
OS	Linux Debian - 10.1
Browser	Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

electron/electron#18397

i believe this was done because we thought it was needed for Network.getCookies, etc, but it does not seem to be used

flotwig · 2020-03-09T19:52:11Z

Running into the weirdest bug with screenshots. If Electron is running in headless mode with video recording disabled, the first Page.captureScreenshot hangs here: https://circleci.com/gh/cypress-io/cypress/276226?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

A response is only received for the second Page.captureScreenshot, taken when the test fails.

Calling Page.startScreencast and Page.stopScreencast around the Page.captureScreenshot call only adds about a millisecond to execution time and works around this issue.

This reverts commit 404803a.

This reverts commit 7a09e36.

This reverts commit 7ac9507.

flotwig · 2020-03-11T16:16:16Z

packages/server/lib/browsers/electron.js

@@ -263,10 +280,7 @@ module.exports = {
  _enableDebugger (webContents) {
    debug('debugger: enable Console and Network')

-    return Bluebird.join(
-      webContents.debugger.sendCommand('Console.enable'),
-      webContents.debugger.sendCommand('Network.enable'),


Network.enable ended up not being necessary, and was probably causing a lot of unnecessary background traffic over the debugger 😬

interesting

packages/server/lib/browsers/electron.js

packages/server/test/unit/request_spec.coffee

cypress-bot · 2020-03-16T20:39:46Z

Released in 4.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.2.0, please open a new issue.

flotwig mentioned this pull request Feb 25, 2020

chore(deps): Update dependency electron to version .x 🌟 #6318

Closed

1 task

flotwig changed the base branch from develop to chrome-80 February 25, 2020 18:41

jennifer-shehane mentioned this pull request Mar 2, 2020

Cypress is unable to load site in v3.5.0 due to "Parse Error" #5602

Closed

flotwig mentioned this pull request Mar 3, 2020

Use CDP to record video for Electron, record video in Electron… #6632

Merged

3 tasks

flotwig force-pushed the electron-8 branch from 00fab9a to 44f2da8 Compare March 3, 2020 21:31

flotwig changed the base branch from chrome-80 to develop March 3, 2020 21:32

flotwig changed the title ~~[WIP] Electron 8~~ Electron 8.0.3 Mar 3, 2020

flotwig force-pushed the electron-8 branch from d81d13f to fb6b4ae Compare March 6, 2020 19:10

electron@8.1.0

71be420

flotwig force-pushed the electron-8 branch from 6eb039b to 71be420 Compare March 6, 2020 19:32

flotwig changed the title ~~Electron 8.0.3~~ Electron 8.1.0 Mar 6, 2020

set app.allowRendererProcessReuse to true

54a7c9d

electron/electron#18397

flotwig mentioned this pull request Mar 9, 2020

No screenshots when DEBUG logs are activated #6662

Closed

flotwig added 5 commits March 9, 2020 13:06

Fix taking screenshots in Electron with debug logs enabled

df78583

explicitly use png format for Page.captureScreenshot

861c2d0

don't need to do Network.enable

5c4a428

i believe this was done because we thought it was needed for Network.getCookies, etc, but it does not seem to be used

yarn.lock

370bf6a

remove dead code

8e5ae01

flotwig added 6 commits March 9, 2020 15:53

start and stop screencast around electron screenshots

ea9a065

update debug logging

4039bed

cypress/browsers:node12.13.0-chrome80-ff73

404803a

fix unit tests

d064a7e

debug e2e tests

7a09e36

detect first available servernum

7ac9507

flotwig force-pushed the electron-8 branch from 2964680 to 7ac9507 Compare March 10, 2020 19:43

flotwig added 2 commits March 10, 2020 15:51

electron@8.1.1

dc7d45f

Merge remote-tracking branch 'origin/develop' into electron-8

359b404

flotwig added 2 commits March 10, 2020 16:30

no reuse

9f5fd84

Revert " cypress/browsers:node12.13.0-chrome80-ff73"

90e1527

This reverts commit 404803a.

flotwig changed the title ~~Electron 8.1.0~~ Electron 8.1.1 Mar 10, 2020

flotwig mentioned this pull request Mar 10, 2020

add node12.13.0-chrome80-ff74 cypress-io/cypress-docker-images#275

Merged

flotwig added 3 commits March 10, 2020 17:12

cypress/browsers:node12.13.0-chrome80-ff74

426171f

Revert "debug e2e tests"

4ef4fb0

This reverts commit 7a09e36.

Revert "detect first available servernum"

8519a07

This reverts commit 7ac9507.

flotwig commented Mar 11, 2020

View reviewed changes

flotwig requested review from a team, brian-mann and kuceb and removed request for a team March 11, 2020 16:16

flotwig added 2 commits March 11, 2020 16:52

Merge branch 'develop' into electron-8

5697cc6

Merge branch 'develop' into electron-8

414655f

kuceb reviewed Mar 13, 2020

View reviewed changes

packages/server/lib/browsers/electron.js Show resolved Hide resolved

brian-mann reviewed Mar 13, 2020

View reviewed changes

packages/server/test/unit/request_spec.coffee Show resolved Hide resolved

flotwig requested review from brian-mann and kuceb March 13, 2020 18:09

brian-mann approved these changes Mar 13, 2020

View reviewed changes

flotwig merged commit 910ac6f into develop Mar 13, 2020

cypress-bot bot locked as resolved and limited conversation to collaborators Mar 16, 2020

flotwig deleted the electron-8 branch January 24, 2022 18:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Electron 8.1.1 #6555

Electron 8.1.1 #6555

flotwig commented Feb 25, 2020 •

edited

Loading

Uh oh!

cypress-bot bot commented Feb 25, 2020

Uh oh!

cypress bot commented Feb 25, 2020 •

edited

Loading

Uh oh!

flotwig commented Mar 9, 2020

Uh oh!

flotwig Mar 11, 2020 •

edited

Loading

Uh oh!

brian-mann Mar 13, 2020

Uh oh!

Uh oh!

Uh oh!

cypress-bot bot commented Mar 16, 2020

Uh oh!

Uh oh!

	it('fails when there is an async error at the root', function () {
	return e2e.exec(this, {
	spec: 'app_spec.js',
	project: pluginsRootAsyncError,
	sanitizeScreenshotDimensions: true,
	snapshot: true,
	expectedExitCode: 1,
	})
	})

Electron 8.1.1 #6555

Electron 8.1.1 #6555

Conversation

flotwig commented Feb 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

Uh oh!

cypress-bot bot commented Feb 25, 2020

PR Review Checklist

User Experience

Functionality

Maintainability

Quality

Internal

Uh oh!

cypress bot commented Feb 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test summary

Run details

Uh oh!

flotwig commented Mar 9, 2020

Uh oh!

flotwig Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brian-mann Mar 13, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cypress-bot bot commented Mar 16, 2020

Uh oh!

Uh oh!

flotwig commented Feb 25, 2020 •

edited

Loading

cypress bot commented Feb 25, 2020 •

edited

Loading

flotwig Mar 11, 2020 •

edited

Loading