-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Electron 8.1.1 #6555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electron 8.1.1 #6555
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
i believe this was done because we thought it was needed for Network.getCookies, etc, but it does not seem to be used
Running into the weirdest bug with screenshots. If Electron is running in headless mode with video recording disabled, the first A response is only received for the second Calling |
This reverts commit 404803a.
@@ -263,10 +280,7 @@ module.exports = { | |||
_enableDebugger (webContents) { | |||
debug('debugger: enable Console and Network') | |||
|
|||
return Bluebird.join( | |||
webContents.debugger.sendCommand('Console.enable'), | |||
webContents.debugger.sendCommand('Network.enable'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Network.enable
ended up not being necessary, and was probably causing a lot of unnecessary background traffic over the debugger 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
Additional details
so video recording will fail until this is fixed:Paint event is not triggered electron/electron#22357 switched to recording via CDP instead: Use CDP to record video for Electron, record video in Electron… #6632cypress/packages/server/test/e2e/3_plugins_spec.js
Lines 32 to 40 in 0105ca7
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?