New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch & ignore ENOTCONN errors when piping Cypress subprocess #5293
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
@flotwig why dep change to |
To fix the build - this PR hadn't been merged at the time: #5294 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
when's the new version coming ? |
I just want to know if there's a temp fix I can perform. `await executeCypressRun('path-to-spec-redacted', "⚕️app👩⚕️", "💻subdomain💻", webTestDescription, "Production Environment", 35000);
function executeCypressRun(spec, domain, subdomain, environment, usualTime){ |
@TaukSnarkyAgrud There's a 1-line patch in the original issue comment that you can use: #5241 |
@flotwig Thanks. I saw 5241 but my understanding didn't coalesce till just now. Working now. |
User facing changelog
Fixed a bug where Cypress would exit with an
ENOTCONN
error at the end of a test run if using Node 12.11.0 or greater on Windows.Additional details
Still trying to reproduce in my Windows VM, but a user in #5241 did say that this patch resolves the issue for them.Was able to reproduce (only in
cypress run
) and confirmed that this patch does fix the issue for Node 12.11.0 and Windows 10.PR Tasks