Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch & ignore ENOTCONN errors when piping Cypress subprocess #5293

Merged
merged 5 commits into from Oct 7, 2019

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Oct 4, 2019

User facing changelog

Fixed a bug where Cypress would exit with an ENOTCONN error at the end of a test run if using Node 12.11.0 or greater on Windows.

Additional details

Still trying to reproduce in my Windows VM, but a user in #5241 did say that this patch resolves the issue for them.

Was able to reproduce (only in cypress run) and confirmed that this patch does fix the issue for Node 12.11.0 and Windows 10.

PR Tasks

  • Have tests been added/updated?

@flotwig flotwig requested a review from a team October 4, 2019 16:02
@cypress
Copy link

cypress bot commented Oct 4, 2019



Test summary

3371 0 47 0


Run details

Project cypress
Status Passed
Commit 48bbe44
Started Oct 7, 2019 4:03 PM
Ended Oct 7, 2019 4:08 PM
Duration 04:32 💡
OS Linux Debian - 9.8
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@kuceb
Copy link
Contributor

kuceb commented Oct 4, 2019

@flotwig why dep change to https-proxy-agent ?

@flotwig
Copy link
Contributor Author

flotwig commented Oct 4, 2019

why dep change to https-proxy-agent ?

To fix the build - this PR hadn't been merged at the time: #5294

Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bahmutov bahmutov merged commit ddf9707 into develop Oct 7, 2019
@michalko
Copy link

michalko commented Oct 9, 2019

when's the new version coming ?

@TaukSnarkyAgrud
Copy link

I just want to know if there's a temp fix I can perform.
I am running async calls from a node script and this fails even when I make them await.

`await executeCypressRun('path-to-spec-redacted', "⚕️app👩‍⚕️", "💻subdomain💻", webTestDescription, "Production Environment", 35000);

    executeCypressRun('path-to-spec-redacted', "⚕️app👩‍⚕️", "📟subdomain📟", emrTestDescription, "Production Environment", 35000);

function executeCypressRun(spec, domain, subdomain, environment, usualTime){
console.log("------------------>Checkpoint1<-----------------")
return cypress.run({
spec: spec,
config: {
defaultCommandTimeout: 10000,
integrationFolder: 'path-to-integration-redacted',
trashAssetsBeforeRuns: true
}
}).then((results) => {
console.log("------------------>Chekpoint2<
-----------------");
analyseThenPostToTeams(results, domain, subdomain, environment, usualTime);
});
}`

@flotwig
Copy link
Contributor Author

flotwig commented Oct 9, 2019

@TaukSnarkyAgrud There's a 1-line patch in the original issue comment that you can use: #5241

@TaukSnarkyAgrud
Copy link

@flotwig Thanks. I saw 5241 but my understanding didn't coalesce till just now. Working now.

@flotwig flotwig deleted the issue-5241-windows-enotconn branch January 24, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENOTCONN error on Windows runs
5 participants