Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration and events overhaul (v6.0) #4225

Closed
wants to merge 61 commits into from
Closed

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented May 17, 2019

Previously this was part of v5.0

Closes #2840

chrisbreiding and others added 30 commits December 3, 2018 11:38
* rename plugins to background

* rename missed directories named plugins

* fix snapshot

* fix plugins references in driver

* error when pluginsFile is used

* throw error when backgroundFile is default but plugins/index.js exists

* fix wrong usage of fs.pathExists

* update desktop-gui pluginsFIle use

* fix e2e spec

* background-guide -> background-process

* fix desktop-gui spec

* rename plugins to background
* Initial upgrade changes

* Some quick fixes

* More fixes

* Clean up exp logic and fix spread array failures

* Remove caret from package.json

* Add handling for proxies in isJquery

* iterate on flaky test, increase default command timeout
* rename ‘command:end’ to ‘internal:commandEnd’

* reanme ‘command:enqueued’ to ‘internal:commandEnqueue’

* rename ‘command:retry’ to ‘internal:commandRetry’

* rename ‘command:start’ to ‘internal:commandStart’

* rename ‘test:run:start’ to ‘test:start’

* rename ‘test:run:end’ to ‘test:end’

* rename ‘viewport:changed’ to ‘viewport:change’

* update page events to take details object

* fix issues with page event changes

* fix failing tests

* fix failing integration tests

* rename background events

* actually rename the background events

* fix tests
# Conflicts:
#	packages/driver/src/cy/commands/xhr.coffee
#	packages/driver/src/dom/jquery.coffee
#	packages/driver/test/cypress/integration/commands/xhr_spec.coffee
#
packages/server/test/support/fixtures/projects/e2e/cypress/integration/x
hr_spec.coffee
…'after:run' (#2331)

* implement before:spec, after:spec, and after:run plugin events

* ensure server events only executed if registered

* don’t execute plugin event if plugins process has been killed

* call default preprocessor directly instead of registering it as plugin

makes things more consistent because now plugins are only registered by the user. this was an exception where we registered it as a plugin, but it’s unnecessary because we can just call it directly

* fix unit tests

* await server events before proceeding

* add before:run plugin event

* pass run details to before:run event

* handle and report errors thrown in server event handlers

* wrap plugin execution in promise

* rename instances of plugin

* more rename fixes

* fix tests

* fix test

* rename events to use ‘start’ instead of ‘before’ and ‘end’ instead of ‘after’

* bump zunder to 6.3.2

* await run & spec events in interactive mode

* fix server unit tests

* fix desktop-gui tests

* fix e2e specs

* fix desktop-gui specs

* fix desktop-gui specs

* add server unit tests for run/spec events in interactive mode

* add/update desktop-gui integration tests for run/spec events

* remove console.log
chrisbreiding and others added 8 commits February 28, 2019 10:08
* reduce race condition so that async error throws before test is finished

* fix snapshot

* update snapshot

* ensure async error isn't thrown more than once

* fix async error file structure, disable supportFile

* update snapshot

* never resolve file to try to keep whitespace output consistent
@jennifer-shehane jennifer-shehane changed the title Cypress v5.0 [WIP] Cypress v5.0 Feb 26, 2020
@chrisbreiding chrisbreiding changed the title [WIP] Cypress v5.0 [WIP] Configuration and events overhaul Mar 6, 2020
@jennifer-shehane jennifer-shehane marked this pull request as draft April 21, 2020 06:29
@jennifer-shehane jennifer-shehane changed the title [WIP] Configuration and events overhaul Configuration and events overhaul (v5.0) Apr 21, 2020
@flotwig flotwig closed this Jun 18, 2020
@flotwig flotwig deleted the v5.0 branch June 18, 2020 15:05
@flotwig
Copy link
Contributor

flotwig commented Jun 18, 2020

Deleted the v5.0 branch since we're moving forward with 5.0 here: #7753

This work can be retrieved from 97ffa34 if it's going to be merged in at some point.

@jennifer-shehane jennifer-shehane changed the title Configuration and events overhaul (v5.0) Configuration and events overhaul (v6.0) Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epic: Configuration and events overhaul
5 participants