misc: More accessibility fixes #29322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…via the keyboard.
jennifer-shehane
changed the title
6 flaky tests on run #55300 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > throws when foo cannot resolve |
Test Replay
|
|
e2e/origin/basic_login.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Multi-step Auth > final auth redirects back to approval page - flat |
| |||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > stops waiting when an fetch request is canceled |
Test Replay
|
|
e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > throws when foo cannot resolve |
Test Replay
|
|
commands/net_stubbing.cy.ts • 2 flaky tests • 5x-driver-webkit
| Test | Artifacts | |
|---|---|---|
| ... > with `resourceType` > can match a proxied image request by resourceType |
Review all test suite changes for PR #29322 ↗︎ | |
jennifer-shehane
changed the title
AtofStryker
approved these changes
Apr 30, 2024
ryanthemanuel
approved these changes
May 2, 2024
jj497
pushed a commit
to jj497/cypress
that referenced
this pull request
May 5, 2024
* misc: Add tabindex to shiki code highlights so that it is accessible via the keyboard. * Add tabindex for code preview in error-header * Change h3 to h2 to meet a11y guidelines for incremental headers * Add roles for landmarks * Move navigation role to correct area * Update main to have singular role * update nav in banner to 'div' so there aren't 2 navs * Have an h1 on the Global page to address a11y violation * Fix aria-disabled attr to have valid 'true' value instead of 'disabled' * Add changelog entry * Fix tests that are looking for aria-disabled to now look for 'true' * chore: fix test that's failing in npm/react test
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Fixing some more a11y violations highlighted originally at https://cloud.cypress.io/projects/ypt4pf/runs/54926/accessibility/
Change h3 level headings to h2 to address this moderate violation which requires headings to not jump numbers. You can see in the new report that this moderate violation is gone.
The heading styles look the same in Percy - see 'Choose a browser'
Addressed various moderate landmark violations so that
main,nav, andbannerare correctly identified in the launchpad via the HTML tag androle. Explanation: https://dequeuniversity.com/rules/axe/4.9/landmark-main-is-top-level?application=axeAPIAddressed critical violation in our CT tests where we're setting
aria-disabled="disabled"instead of the properly attr value ofaria-disabled=true.Steps to test
Check the new a11y report and that all existing tests and percy checks pass.
Also Percy indicated no visual changes from this PR.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?