Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support vite-dev-server middlewareMode #29219

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mucsi96
Copy link

@mucsi96 mucsi96 commented Mar 28, 2024

Allow using vite dev server in middlerware mode as original does. See: https://vitejs.dev/config/server-options.html#server-middlewaremode

Helps resolving issues with MSW by allowing serving mock service worker from root.

PR Tasks

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2024

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@jennifer-shehane
Copy link
Member

@mucsi96 Thanks for the contribution! Are you able to add some tests around this behavior?

@jennifer-shehane
Copy link
Member

@mucsi96 We'll be unable to merge this change without tests verifying the behavior.

@mucsi96
Copy link
Author

mucsi96 commented Apr 17, 2024

Hi! Sorry I got busy with work items. Let me try add a test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants