chore(dependency): Upgrade Electron 28 #28959
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 failed and 5 flaky tests on run #54423 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| errors ui > hooks |
Test Replay
Screenshots
|
|
| errors ui > typescript |
Test Replay
Screenshots
|
|
cypress\e2e\studio\studio.cy.ts • 2 failed tests • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress Studio > updates an existing test with a click action |
Test Replay
Screenshots
|
|
| Cypress Studio > writes a test with all kinds of assertions |
Test Replay
Screenshots
|
|
cypress\e2e\runner\reporter.hooks.cy.ts • 1 failed test • app-e2e
| Test | Artifacts | |
|---|---|---|
| hooks > creates open in IDE button |
Test Replay
Screenshots
|
|
cypress\e2e\create-from-component.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| ... > runs generated spec |
Test Replay
Screenshots
|
|
cypress\e2e\specs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| ... > shows create first spec page with scaffold and create template spec options |
Test Replay
Screenshots
|
|
cypress\e2e\top-nav.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| ... > with no project id > shows "connect project" button after login if no project id is set |
Test Replay
Screenshots
|
|
cypress\e2e\specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Test Replay
Screenshots
|
|
cypress\e2e\migration.cy.ts • 1 flaky test • launchpad-e2e
| Test | Artifacts | |
|---|---|---|
| global mode > migrates 2 projects in global mode |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #28959 ↗︎
…nto electron-28
| @@ -213,7 +213,7 @@ class SourcemapSupport { | |||
| frame = cloneCallSite(frame) | |||
|
|
|||
| frame.getFileName = function getFileName () { | |||
| return pos.source || pos.name || null | |||
| return pos.source || pos.name || undefined | |||
There was a problem hiding this comment.
This type check was failing, likely due to upgrading types/node. https://app.circleci.com/pipelines/github/cypress-io/cypress/59945/workflows/36318f1d-bf0e-42e7-b0bc-3fa50a5b29f5/jobs/2493950
yarn.lock
Outdated
| integrity sha512-2s6B2CWZM//kPgwnuI0KrYwNjfdByE25zvAaEpq9IH4zcNsarH8Ihu/UuX6XMPEogDAxkuUFeZn60pXNHAqn3A== | ||
| version "3.54.0" | ||
| resolved "https://registry.yarnpkg.com/node-abi/-/node-abi-3.54.0.tgz#f6386f7548817acac6434c6cba02999c9aebcc69" | ||
| integrity sha512-p7eGEiQil0YUV3ItH4/tBb781L5impVmmx2E9FRKF7d18XXzp4PGT2tdYMFY6wQqgxD0IwNZOiSJ0/K0fSi/OA== |
There was a problem hiding this comment.
node-abi error was encountered, so needed to bump this. electron/forge#667
| @@ -181,6 +181,7 @@ export class DataContext { | |||
| @cached | |||
| get cloud () { | |||
| return new CloudDataSource({ | |||
| // @ts-ignore | |||
| fetch: (...args) => this.util.fetch(...args), | |||
There was a problem hiding this comment.
To address error below. Open to better ideas here. https://app.circleci.com/pipelines/github/cypress-io/cypress/59948/workflows/efa9b4b3-12ca-4f83-a8d7-d5c9186f28d4/jobs/2493976
| @@ -16,7 +16,7 @@ | |||
| "types": [ | |||
| "cypress", | |||
| "./support", | |||
| "./node_modules/@types/node" | |||
| "node" | |||
There was a problem hiding this comment.
This comment was marked as resolved.
This comment was marked as resolved.
|
@MikeMcC399 Removed that reference. |
This was referenced Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?