fix: Use resolved git root on Windows

[mike-plummer]

• Closes Flaky test: Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/root/cypress/packages/data-context/test/unit/sources/GitDataSource.spec.ts) #23317

Additional details

Flaky test does not reproduce locally on M1, but from logs I believe the issue is that we are initializing the gitBaseDir field asynchronously, which means Git commands run immediately after creation might execute against the cypress repository rather than the scaffolded project.

Currently, we use the resolved Git repo root as cwd for bulk Git ops on Unix, but the project directory on Windows which could be incorrect based on project structure.

• Initialize GitDataSource's base dir to the project directory, replaced by existing logic during async setup flow
• Cleanup GitDataSource tests
  • use async fs APIs
  • await callback promises rather than polling
  • await cleanup items between tests

Steps to test

Existing tests should cover

How has the user experience changed?

No user-facing change, should only impact unit tests due to quick execution of test before async setup flow completes and replaces git repo root

PR Tasks

• Have tests been added/updated?
• [na] Has a PR for user-facing changes been opened in cypress-documentation?
• [na] Have API changes been updated in the type definitions?

[cypress]

30 flaky tests on run #44973 ↗︎

0

26895

1281

0

30

Details:

Merge branch 'develop' into mikep/23317-flaky-git-test
Project: cypress	Commit: 8bf4d0692e
Status: Passed	Duration: 19:03 💡
Started: Mar 27, 2023 4:53 PM	Ended: Mar 27, 2023 5:12 PM

  project-setup.cy.ts • 1 flaky test • launchpad-e2e

View Output Video

Test		Artifacts
... > skips the setup page when choosing e2e tests to run		Output Screenshots Video

  global-mode.cy.ts • 1 flaky test • launchpad-e2e

View Output Video

Test		Artifacts
... > can be opened		Output Screenshots Video

  e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output Video

Test		Artifacts
cy.origin - cookie login > Max-Age > past max-age -> not logged in		Output Video

  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output Video

Test		Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse		Output Video

  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-chrome:beta

View Output Video

Test		Artifacts
... > correctly returns currentRetry		Output Video
... > correctly returns currentRetry		Output Video
... > correctly returns currentRetry		Output Video

The first 5 flaky specs are shown, see all 18 specs in Cypress Cloud.

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[astone123]

Nice 👍🏻

[warrensplayer]

One comment, but not a blocker. I like the updates to the test.