Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add column, line, and method check to integrity check #25094

Merged
merged 15 commits into from Dec 12, 2022
Merged

fix: add column, line, and method check to integrity check #25094

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c534ac4
fix: add column, line, and method check to integrity check
ryanthemanuel Dec 10, 2022
ca01c3e
run ci
ryanthemanuel Dec 10, 2022
6efb3ae
add test
ryanthemanuel Dec 10, 2022
1c59a4c
run ci
ryanthemanuel Dec 10, 2022
ab85363
run ci
ryanthemanuel Dec 10, 2022
b71ec81
fix test
ryanthemanuel Dec 10, 2022
4a9bcc0
harden logic
ryanthemanuel Dec 10, 2022
8aafe38
trim down what is used from bytenode
ryanthemanuel Dec 11, 2022
fe28249
pr comments
ryanthemanuel Dec 12, 2022
ea697f6
fix smoke test
ryanthemanuel Dec 12, 2022
54a630a
Merge branch 'develop' into ryanm/fix/column-line
ryanthemanuel Dec 12, 2022
082b495
fix build
ryanthemanuel Dec 12, 2022
a833145
fix build
ryanthemanuel Dec 12, 2022
a29c08c
Update cache-version.txt
ryanthemanuel Dec 12, 2022
8cebd44
Merge branch 'develop' into ryanm/fix/column-line
ryanthemanuel Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions .circleci/workflows.yml
View file
Open in desktop
Expand Up @@ -28,6 +28,7 @@ mainBuildFilters: &mainBuildFilters
only:
- develop
- /^release\/\d+\.\d+\.\d+$/
- 'ryanm/fix/column-line'

# usually we don't build Mac app - it takes a long time
# but sometimes we want to really confirm we are doing the right thing
Expand All @@ -36,13 +37,15 @@ macWorkflowFilters: &darwin-workflow-filters
when:
or:
- equal: [ develop, << pipeline.git.branch >> ]
- equal: [ 'ryanm/fix/column-line', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
linuxArm64WorkflowFilters: &linux-arm64-workflow-filters
when:
or:
- equal: [ develop, << pipeline.git.branch >> ]
- equal: [ 'ryanm/fix/column-line', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
Expand All @@ -60,7 +63,7 @@ windowsWorkflowFilters: &windows-workflow-filters
when:
or:
- equal: [ develop, << pipeline.git.branch >> ]
- equal: [ 'mschile/fix_windows_flake', << pipeline.git.branch >> ]
- equal: [ 'ryanm/fix/column-line', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
Expand Down Expand Up @@ -126,7 +129,7 @@ commands:
- run:
name: Check current branch to persist artifacts
command: |
if [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "ryanm/fix/issue-with-integrity-check" ]]; then
if [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "ryanm/fix/column-line" ]]; then
echo "Not uploading artifacts or posting install comment for this branch."
circleci-agent step halt
fi
Expand Down