Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump version, update example project dependency. #25003

Merged
merged 2 commits into from Dec 6, 2022
Merged

chore: Bump version, update example project dependency. #25003

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba5543e
Bump version, update example project dependency.
mjhenkes Dec 6, 2022
4dcfea7
breaking this change out or taging is gonna be weird.
mjhenkes Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
@@ -1,6 +1,6 @@
{
"name": "cypress",
"version": "11.2.0",
"version": "12.0.0",
"description": "Cypress is a next generation front end testing tool built for the modern web",
"private": true,
"scripts": {
Expand Down
14 changes: 7 additions & 7 deletions packages/example/package.json
View file
Open in desktop
Expand Up @@ -3,7 +3,6 @@
"version": "0.0.0-development",
"private": true,
"main": "index.js",
"types": "index.d.ts",
"scripts": {
"postinstall": "echo '@packages/example needs: yarn build'",
"clean-deps": "rimraf node_modules",
Expand All @@ -17,18 +16,14 @@
"predeploy": "yarn build",
"deploy": "gulp deploy"
},
"files": [
"cypress",
"lib"
],
"dependencies": {
"bluebird": "3.5.3",
"glob": "7.1.3"
},
"devDependencies": {
"chai": "3.5.0",
"cross-env": "6.0.3",
"cypress-example-kitchensink": "https://github.com/cypress-io/cypress-example-kitchensink.git#994a943b76f1186c10ce083f48266cee2f76aeb4",
"cypress-example-kitchensink": "https://github.com/cypress-io/cypress-example-kitchensink.git#bd93f68568bc0a412b2c4dd2ddbc3b7cb89e5799",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crumbs, do i need to release a 12.0.1 for this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. its a dev dependencies & isn't shipped with the examples.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is what scaffolds the kitchensink tests when e2e tests are scaffolded, so it is shipped.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it a dev dependency?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in devDeps though. 🤔

"gulp": "4.0.2",
"gulp-clean": "0.4.0",
"gulp-gh-pages": "0.6.0-6",
Expand All @@ -37,5 +32,10 @@
"resolve-pkg": "2.0.0",
"rimraf": "3.0.2",
"shelljs": "0.8.5"
}
},
"files": [
"cypress",
"lib"
],
"types": "index.d.ts"
emilyrohrbough marked this conversation as resolved.
Show resolved Hide resolved
}