Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix windows-lint CI job #24758

Merged
merged 6 commits into from Nov 22, 2022
Merged

fix: fix windows-lint CI job #24758

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
763974a
fix: fix windows-lint job?
astone123 Nov 18, 2022
80a7d76
fix: try forcing git to use LF
astone123 Nov 21, 2022
e9b6228
fix: resolve other lint warnings
astone123 Nov 21, 2022
fcc475d
fix: try using .gitattributes instead
astone123 Nov 21, 2022
36ef6fc
fix: cap lint command at 2 concurrent threads
astone123 Nov 21, 2022
375f736
fix: resolve merge conflicts
astone123 Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Expand Up @@ -63,7 +63,7 @@ windowsWorkflowFilters: &windows-workflow-filters
when:
or:
- equal: [ develop, << pipeline.git.branch >> ]
- equal: [ 'ryanm/fix/typescript-issue', << pipeline.git.branch >> ]
- equal: [ 'astone123/fix-windows-lint', << pipeline.git.branch >> ]
- matches:
pattern: "-release$"
value: << pipeline.git.branch >>
Expand Down
2 changes: 2 additions & 0 deletions .gitattributes
View file
Open in desktop
Expand Up @@ -2,4 +2,6 @@

*.json text eol=lf

**/.eslintrc text eol=lf
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the change that makes the windows-lint job pass again


packages/errors/__snapshot-html__/** linguist-generated=true
5 changes: 4 additions & 1 deletion npm/vue/cypress/component/test-utils-api/TestUtilsApi.vue
View file
Open in desktop
Expand Up @@ -6,7 +6,10 @@
<script>
export default {
props: {
msg: String,
msg: {
type: String,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this was to resolve one of the warnings that was showing up during linting just to clean some things up. It looks like ESLint requires a default for Vue props the way we have it configured, or else it warns.

default: '',
},
},
data () {
return {
Expand Down
1 change: 1 addition & 0 deletions npm/webpack-batteries-included-preprocessor/.eslintignore
View file
Open in desktop
@@ -0,0 +1 @@
**/tsconfig.json
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -42,7 +42,7 @@
"get-next-version": "node scripts/get-next-version.js",
"postinstall": "node ./scripts/run-postInstall.js",
"jscodeshift": "jscodeshift -t ./node_modules/js-codemod/transforms/arrow-function-arguments.js",
"lint": "lerna run lint --no-bail",
"lint": "lerna run lint --no-bail --concurrency 2",
"lint-changed": "lint-changed",
"prepare-release-artifacts": "node ./scripts/prepare-release-artifacts.js",
"npm-release": "node scripts/npm-release.js",
Expand Down
1 change: 1 addition & 0 deletions packages/errors/.eslintignore
View file
Open in desktop
@@ -0,0 +1 @@
**/tsconfig.json
1 change: 1 addition & 0 deletions packages/graphql/.eslintignore
View file
Open in desktop
@@ -0,0 +1 @@
**/tsconfig.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't we want to lint the tsconfig?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added these ignore files because there's a plugin that is already skipping these files and when it does it logs a warning. Wanted to clean those up

/root/cypress/packages/graphql/tsconfig.json
  0:0  warning  [@cypress/eslint-plugin-json]: Skipping file due to "json/json-with-comments-files" setting: 
  ["**/tsconfig.json", ".vscode/**"]
To remove this warning add "tsconfig.json" to your `.eslintignore` file

1 change: 1 addition & 0 deletions packages/network/.eslintignore
View file
Open in desktop
@@ -0,0 +1 @@
**/tsconfig.json
1 change: 1 addition & 0 deletions packages/proxy/.eslintignore
View file
Open in desktop
@@ -0,0 +1 @@
**/tsconfig.json
1 change: 1 addition & 0 deletions packages/resolve-dist/.eslintignore
View file
Open in desktop
@@ -0,0 +1 @@
**/tsconfig.json
1 change: 1 addition & 0 deletions packages/scaffold-config/.eslintignore
View file
Open in desktop
@@ -0,0 +1 @@
**/tsconfig.json
1 change: 1 addition & 0 deletions packages/socket/.eslintignore
View file
Open in desktop
@@ -0,0 +1 @@
**/tsconfig.json
1 change: 1 addition & 0 deletions packages/types/.eslintignore
View file
Open in desktop
@@ -0,0 +1 @@
**/tsconfig.json