New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: limit CI runs #24755
chore: limit CI runs #24755
Conversation
…io/cypress into emily/dynamic-cirlce-ci
Thanks for taking the time to open a PR!
|
@@ -0,0 +1,2898 @@ | |||
version: 2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is 1:1 with the previous config.yml
file. CircelCI uses config.yml
by default. This change is to simple limit kicking off the workflows. Over time, plan to make enhancements to the dynamic configuration to simplify this setup.
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
…io/cypress into emily/dynamic-cirlce-ci
@@ -1,2907 +1,70 @@ | |||
version: 2.1 | |||
setup: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any tips to review this PR? There's a lot of red and green, but I suspect the code changes are quite minimal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workflows.yml should be 1:1 copy of config.yml in develop, so copy & paste and see nothing changed? I was bummed the diff on config.yml was so rough. config.yml is all new content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, ok, so I just need to really look at
Line 26 in 1ac9a10
cancel_build () { |
Bash is gnarly, if it works it works -- cool hack on downloading the workflows.yml:
Line 61 in 1ac9a10
curl -o workflows.yml https://raw.githubusercontent.com/${CIRCLE_PROJECT_USERNAME}/${CIRCLE_PROJECT_REPONAME}/${CIRCLE_BRANCH}/.circleci/workflows.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see little to no risk in this change, so ✔️
# Conflicts: # .circleci/config.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! We should probably announce a summary of these changes in Slack just so that people know what's going on 👍🏻
# Conflicts: # .circleci/config.yml
Rules
Trigger Pipeline
buttonChanges
Trigger Pipeline
or by push a new commit with any message.