New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: minor style updates & fix a windows test #24558
Merged
Merged
Changes from 17 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
cb86749
wait for config initialization to be complete
marktnoonan a2ac561
increase timeout for cy-in-cy on windows
marktnoonan 2060532
run more CI steps on this branch
marktnoonan 57fdfc3
tweak border, fix double scrollbar
marktnoonan 430d356
reach choose a browser page before login in launchpad test
marktnoonan ed3c0ff
revert timeout change
marktnoonan 69559fb
chore: update vite in system test
lmiller1990 af43f3f
Merge branch 'develop' into marktnoonan/windows-test-updates
lmiller1990 2bf78a6
Fixing value for monthIndex to Date.UTC
warrensplayer 7ef06fa
chore: fix test date
astone123 71a9418
Merge branch 'develop' into marktnoonan/windows-test-updates
astone123 75d25ca
chore: fix tests in reporter-ct-mount-hover.cy.ts
astone123 5cca59a
try fixing some flake
lmiller1990 12174a4
fix yarn lock
lmiller1990 aeaae33
conditionally skip flaky test on windows
lmiller1990 1924e6a
note on skipped test
lmiller1990 79ccaae
chore: skip flaky tests on windows only [skip ci]
lmiller1990 4cb9aef
Merge remote-tracking branch 'origin/develop' into marktnoonan/window…
lmiller1990 46a480f
Merge branch 'develop' into marktnoonan/windows-test-updates
lmiller1990 995dc7e
Merge branch 'marktnoonan/windows-test-updates' of https://github.com…
lmiller1990 4d4bb26
update exports and snaps
lmiller1990 223b35b
correctly use describe instead of it
lmiller1990 3fff7d1
fix types
lmiller1990 aa5c5fa
do not run windows anymore
lmiller1990 6b61388
add comment [skip ci]
lmiller1990 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Race condition - sometimes the rest actually executes fast enough, and it's not
--
, but the number of passes. So, better just verify the elements exist.