feat: enhance test error UI

[emilyrohrbough]

• Apart of [sessions] Improve Validation Error UI in Recreated Session #21398 - This portion updates the UI for better error handling in cy.session(). Next step will be to update how cy.session() captures and reports these errors. It was getting too big when doing the work all-in-one.

User facing changelog

I wouldn't necessarily call these note-worthy changes for the changelog. Addressed in #24266.

• Enhancements were made to improve the UI around reporter test errors in the Reporter.

User Facing Changing

Review Percy screenshots to see the full impact of changes.

(edit: latest push tweaked these a bit, but these are the general look. See Percy!)

Test Error:

Recovered In-Test Error (currently only observed when using cy.session())

PR Tasks

• Have tests been added/updated?
• Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
• [] Has a PR for user-facing changes been opened in cypress-documentation?
• [n/a] Have API changes been updated in the type definitions?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[emilyrohrbough]

Note for Monday -- this is where the fail-indicator class came from -- verify you don't need to re-add vertical-align: middle

[cypress]

---

Test summary

45914 • 0 • 4489 • 0 • 6

---

Run details

Project	cypress
Status	Passed
Commit	56f4c2a
Started	Oct 17, 2022 4:30 PM
Ended	Oct 17, 2022 4:47 PM
Duration	17:41 💡
OS	Linux Debian - 11.4
Browser	Multiple

View run in Cypress Dashboard ➡️

---

Flakiness

	commands/xhr.cy.js		1
1	src/cy/commands/xhr > abort > aborts xhrs currently in flight
	specs_list_latest_runs.cy.ts		1
1	App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs
	e2e/origin/config_env.cy.ts		1
1	cy.origin- Cypress.config() > serializable > overwrites different values in secondary, even if the Cypress.config() value does not exist in the primary
	e2e/origin/commands/navigation.cy.ts		1
1	cy.origin navigation > #consoleProps > .go()
	next.cy.ts		1
1	Working with next-11 > should show compilation errors on src changes
This comment includes only the first 5 flaky tests. See all 6 flaky tests in the Cypress Dashboard.

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[AtofStryker]

Is the goal of isRecovered to eventually be used outside of cy.session? Does that mean session validation fails but the rest of the test continues?

[emilyrohrbough]

Is the goal of isRecovered to eventually be used outside of cy.session?

Not necessarily, this is just cleaning up how this is currently implemented. I could see this potentially being used in the future by other "workflow-like" commands but there are no plans ATM that I am away of to create others commands of this style. Think of this as a try-catch-finally or try-catch-try_something_else.

Does that mean session validation fails but the rest of the test continues?

Yes, it does. In the context of cy.session() this only apply in this flow:
restore session -> validate session -> FAIL validation -> recreate session -> validate session -> if pass continue to next command OR if fail, fail test

[AtofStryker]

wonder if we want to name the isRecovered to something session specific until it is used more generically later? Either way changes look good on my end!

[mjhenkes]

Would it make sense to share this logic with the attempt-model?