Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't install jest in circle ci job because of broken 3rd party … #23113

Merged
merged 1 commit into from Aug 4, 2022

Conversation

BlueWinds
Copy link
Contributor

@BlueWinds BlueWinds commented Aug 4, 2022

…deps

User facing changelog

No user-facing changes.

Additional details

yargs-parser recently shipped a version with broken / conflicting types. yargs/yargs-parser#452. Because of this, one of our CI tasks (test-types-cypress-and-jest) that npm install jest is failing.

This PR temporarily disables that job, until yargs-parser / jest sort out their problems. @BlueWinds is watching the above issue, and will follow up to re-enable this when it's safe to do so.

Steps to test

CI build passes in this branch, and in no other branches.

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 4, 2022

Thanks for taking the time to open a PR!

@BlueWinds
Copy link
Contributor Author

Since this a change only to a single circleci task, and that task has now passed, going to merge in without waiting for a completely green build.

@BlueWinds BlueWinds merged commit fe3d898 into develop Aug 4, 2022
@BlueWinds BlueWinds deleted the fix-broken-jest-ci branch August 4, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants