Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(angular): handle mounting teardown before tests #23098

Merged
merged 6 commits into from Aug 4, 2022

Conversation

jordanpowell88
Copy link
Collaborator

@jordanpowell88 jordanpowell88 commented Aug 3, 2022

User facing changelog

Teardown the previous component from the DOM before every test is run

Additional details

This was pointed out by @brian-mann

Steps to test

run the angular.cy.ts system test

How has the user experience changed?

Tests were setup to take a screenshot before each test...

Before:

Screen.Recording.2022-08-03.at.5.09.29.PM.mov

After:

Screen.Recording.2022-08-03.at.5.10.44.PM.mov

PR Tasks

  • [X ] Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na ] Have API changes been updated in the type definitions?

@jordanpowell88 jordanpowell88 requested review from a team as code owners August 3, 2022 21:14
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 3, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Aug 3, 2022



Test summary

37835 0 456 0Flakiness 10


Run details

Project cypress
Status Passed
Commit 4fd707b
Started Aug 4, 2022 4:01 PM
Ended Aug 4, 2022 4:21 PM
Duration 20:00 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/commands/xhr.cy.js Flakiness
1 ... > logs request + response headers
2 ... > logs Method, Status, URL, and XHR
3 ... > logs response
4 ... > logs request + response headers
5 ... > logs Method, Status, URL, and XHR
This comment includes only the first 5 flaky tests. See all 10 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990 lmiller1990 removed the request for review from a team August 3, 2022 21:32
@lmiller1990
Copy link
Contributor

Code seems correct - not sure what's up with CI?

@BlueWinds
Copy link
Contributor

Code seems correct - not sure what's up with CI?

yargs/yargs-parser#452 is currently causing the test-types-cypress-and-jest job to fail. Can't speak to the rest of it.

@ZachJW34 ZachJW34 changed the title ref(angular): handle mounting teardown before tests refactor(angular): handle mounting teardown before tests Aug 3, 2022
@ZachJW34 ZachJW34 self-requested a review August 4, 2022 15:55
@ZachJW34 ZachJW34 merged commit 65cbac8 into angular-ct Aug 4, 2022
@ZachJW34 ZachJW34 deleted the zachw/angular-ct-teardown branch August 4, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants