New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(angular): handle mounting teardown before tests #23098
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Code seems correct - not sure what's up with CI? |
yargs/yargs-parser#452 is currently causing the |
This reverts commit beb0824.
53bedc6
to
4fd707b
Compare
User facing changelog
Teardown the previous component from the DOM before every test is run
Additional details
This was pointed out by @brian-mann
Steps to test
run the
angular.cy.ts
system testHow has the user experience changed?
Tests were setup to take a screenshot before each test...
Before:
Screen.Recording.2022-08-03.at.5.09.29.PM.mov
After:
Screen.Recording.2022-08-03.at.5.10.44.PM.mov
PR Tasks
cypress-documentation
?type definitions
?