Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add experimentalModifyObstructiveThirdPartyCode documentation … #23088

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Aug 3, 2022

…to settings page and experiments

User facing changelog

Adds documentation to experimentalModifyObstructiveThirdPartyCode flag on the settings page in open mode.

Additional details

When merging #22568, I forgot to at the locale documentation for experimentalModifyObstructiveThirdPartyCode. Mistake on my part, but the good news is it is easy added!

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 3, 2022

Thanks for taking the time to open a PR!

@AtofStryker AtofStryker marked this pull request as ready for review August 3, 2022 14:38
@AtofStryker AtofStryker requested a review from a team as a code owner August 3, 2022 14:38
@AtofStryker AtofStryker requested review from marktnoonan, chrisbreiding, emilyrohrbough, flotwig, mjhenkes and mschile and removed request for a team August 3, 2022 14:38
@cypress
Copy link

cypress bot commented Aug 3, 2022



Test summary

4936 0 66 0Flakiness 1


Run details

Project cypress
Status Passed
Commit 13ad12b
Started Aug 4, 2022 2:07 PM
Ended Aug 4, 2022 2:21 PM
Duration 14:12 💡
OS Linux Debian - 11.3
Browser Firefox 99

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/e2e/origin/commands/assertions.cy.ts Flakiness
1 cy.origin assertions > #consoleProps > .should() and .and()

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@AtofStryker
Copy link
Contributor Author

merging in. Build is failing due to test-types-cypress-and-jest having a bad publish of yargs-parser, tracked via yargs/yargs-parser#452

@AtofStryker AtofStryker merged commit 3a78e1f into develop Aug 4, 2022
@AtofStryker AtofStryker deleted the chore/add-experimentalModifyObstructiveThirdPartyCode-locale branch August 4, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

experimentalModifyObstructiveThirdPartyCode does not have a name and description in the cypress settings page.
4 participants