Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add types to screenshots #22768

Merged
merged 11 commits into from Jul 18, 2022
Merged

chore: add types to screenshots #22768

merged 11 commits into from Jul 18, 2022

Conversation

AtofStryker
Copy link
Contributor

User facing changelog

N/A

Additional details

Goal of this PR is to act as a chore to make the types within the screenshot code a bit more accurate

Steps to test

N/A

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 13, 2022

Thanks for taking the time to open a PR!

Base automatically changed from bugfix/screenshot-blackouts to develop July 13, 2022 19:16
@cypress
Copy link

cypress bot commented Jul 13, 2022



Test summary

37729 0 456 0Flakiness 6


Run details

Project cypress
Status Passed
Commit 820f74b
Started Jul 18, 2022 8:36 PM
Ended Jul 18, 2022 8:54 PM
Duration 18:23 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/actions/click.cy.js Flakiness
1 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth
commands/xhr.cy.js Flakiness
1 ... > logs response
cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged first
2 ... > intercept log has consoleProps with intercept info
3 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged first
This comment includes only the first 5 flaky tests. See all 6 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@AtofStryker AtofStryker marked this pull request as ready for review July 13, 2022 21:13
@AtofStryker AtofStryker requested a review from a team as a code owner July 13, 2022 21:13
@AtofStryker AtofStryker requested review from BlueWinds, mschile and lmiller1990 and removed request for a team and BlueWinds July 13, 2022 21:13
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good, glad to see we are increasing usage of TS (although some parts of Cypress are not very TS friendly, heh).

Comment on lines 138 to 140
// Window.Event is private and also deprecated. See https://developer.mozilla.org/en-US/docs/Web/API/Window/event.
// @ts-ignore
win.dispatchEvent(new win.Event('scroll'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the link you referenced is for window.event not the Event interface.

Suggested change
// Window.Event is private and also deprecated. See https://developer.mozilla.org/en-US/docs/Web/API/Window/event.
// @ts-ignore
win.dispatchEvent(new win.Event('scroll'))
win.dispatchEvent(new Event('scroll'))

or you can add Event to:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops 😅. Updated in 5257d7e and also checked the tests for #6099 and looks good.

@AtofStryker AtofStryker requested a review from mschile July 15, 2022 14:16
@AtofStryker AtofStryker merged commit 89acf9c into develop Jul 18, 2022
@AtofStryker AtofStryker deleted the chore/screenshot-types branch July 18, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants