Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add context for run-new-ui-tests dependent jobs #22561

Closed
wants to merge 1 commit into from

Conversation

ZachJW34
Copy link
Contributor

User facing changelog

n/a

Additional details

With #22326 merged in, internal PRs were no longer recording to the dashboard since the jobs didn't have the test-runner:cypress-record-key context and thus didn't have MAIN_RECORD_KEY available.

I thought about changing the MAIN_RECORD_KEY to TEST_LAUNCHPAD_RECORD_KEY but there is a fallback to MAIN_RECORD_KEY in the script so I settled on adding the additional context.

Steps to test

Look at a PR from an internal contributor after #22326 was merged, example:

Screen Shot 2022-06-28 at 11 01 12 AM

notice the use of --spec which should only be used for external contributor test splitting.

A build from this PR looks like:
Screen Shot 2022-06-28 at 11 03 42 AM

This build is now using the --record flag as intended

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 28, 2022

Thanks for taking the time to open a PR!

@flotwig
Copy link
Contributor

flotwig commented Jun 28, 2022

@ZachJW34 is this a dupe of #22559 ?

@ZachJW34
Copy link
Contributor Author

@flotwig didn't see that one... it is indeed a duplicate. I added it in a few extra places so let me check if that's something we need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants