Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make spec migration screen text more generic #22325

Merged
merged 2 commits into from Jun 16, 2022
Merged

chore: make spec migration screen text more generic #22325

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42b1269
chore: make spec migration screen text more generic
lmiller1990 Jun 15, 2022
fe93821
update language
lmiller1990 Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/frontend-shared/src/locales/en-US.json
View file
Open in desktop
Expand Up @@ -597,8 +597,8 @@
"title": "Migration Helper",
"description": "Complete the steps below to migrate your project to Cypress 10",
"step1": {
"title": "Rename existing specs",
"description": "In this step, we'll automatically rename and move your existing spec files.",
"title": "Migrate existing specs",
"description": "In this step, we'll automatically rename and/or move your existing spec files as needed.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simpler version, up to you!

Suggested change
"description": "In this step, we'll automatically rename and/or move your existing spec files as needed.",
"description": "In this step, we'll automatically update your existing spec file paths.",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahaha just caught up on the whole thread on wording between you and @marktnoonan . My 2 cents is that rename and/or move is a bit wordy and makes me think, whereas "update" covers both and I don't have to cerebrally digest what's happening. It's a simple thing we're doing, imo the markup should be short & sweet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I read "update" I feel like like it could do absolutely anything to my files. It's not clear that the changes are limited to moving/renaming, that in this step we aren't going to actually touch the internals of files (like we do other places).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if it's "update your existing spec file paths" instead of "update your existing spec files"?

fwiw I'm not married to either approach and will support whatever you choose 😃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with either, just gonna ship this as is. I think they are both fine and combined with the UI, it's pretty clear what's going on.

"button": "Rename these specs for me",
"buttonSkip": "Skip renaming specs",
"buttonRenameFolder": "Rename the folder for me"
Expand Down Expand Up @@ -722,4 +722,4 @@
"alpha": "Alpha",
"beta": "Beta"
}
}
}