Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make spec migration screen text more generic #22325

Merged
merged 2 commits into from Jun 16, 2022
Merged

chore: make spec migration screen text more generic #22325

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42b1269
chore: make spec migration screen text more generic
lmiller1990 Jun 15, 2022
fe93821
update language
lmiller1990 Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/frontend-shared/src/locales/en-US.json
View file
Open in desktop
Expand Up @@ -543,7 +543,7 @@
"after": "After",
"heresWhy": "here's why:",
"renameAuto": {
"title": "We recommend automatically renaming your specs in this step",
"title": "We recommend automatically updating your specs in this step",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"updating" sounds to broad to me, what we recommend is definitely renaming. This title probably doesn't need a change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, reverted

"changeButton": "change",
"changedSpecFolder": "We've changed the default spec folder from:",
"changedSpecExt": "We've changed the default spec file extension from:",
Expand Down Expand Up @@ -598,7 +598,7 @@
"description": "Complete the steps below to migrate your project to Cypress 10",
"step1": {
"title": "Rename existing specs",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the screenshot, this title is changed, but it's not here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I might have missed a commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, let's use "Migrate existing specs" for the title. It's the perfect description for what we are doing, it's the migration UI, after all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

I also updated the screenshot.

"description": "In this step, we'll automatically rename and move your existing spec files.",
"description": "In this step, we'll automatically change existing spec files to match the new convention.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also seems too broad compared to what we have now. How about:

In this step, we'll automatically rename and/or move your existing spec files as needed.

Which keeps the scope narrow to what we will actually do, and allows it to be correct even if we are only doing one thing or the other. We could leave all other text the same I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually had some variation of this but ended up flip flopping back to "update", but happy to go with this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

"button": "Rename these specs for me",
"buttonSkip": "Skip renaming specs",
"buttonRenameFolder": "Rename the folder for me"
Expand Down Expand Up @@ -722,4 +722,4 @@
"alpha": "Alpha",
"beta": "Beta"
}
}
}