fix: ensure that proxy logs are updated after the xhr has actually completed #21373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompleted (cherry picked from commit 73a4cd4)
ryanthemanuel
requested review from
jennifer-shehane
and removed request for
a team
|
Thanks for taking the time to open a PR!
|
ryanthemanuel
requested review from
flotwig and
mschile
and removed request for
jennifer-shehane
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
mschile
requested changes
May 6, 2022
mschile
approved these changes
May 6, 2022
flotwig
approved these changes
May 6, 2022
| } | ||
|
|
||
| if (proxyRequest.xhr && proxyRequest.xhr.xhr.readyState !== XMLHttpRequest.DONE) { | ||
| proxyRequest.xhr.xhr.addEventListener('load', () => { |
flotwig
changed the title
ryanthemanuel
deleted the
ryanm/fix/21361-fix-proxy-logging-with-xhr-develop
branch
AtofStryker
pushed a commit
that referenced
this pull request
May 9, 2022
…mpleted (#21373) Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
tgriesser
added a commit
that referenced
this pull request
May 13, 2022
* 10.0-release: (22 commits) fix: migrate multiples projects when in global mode (#21458) test: fix flaky cy-in-cy selector validity test (#21360) chore: remove unused codeGenGlobs (#21438) fix: use correct path for scaffolding spec on CT (#21411) fix: remove breaking options from testing type on migration (#21437) fix: test-recording instructions in Component Test mode (#21422) feat: distinguish app vs launchpad utm_source when using utm params (#21424) chore: update stubbed cloud types (#21451) chore: change to yarn registry fix(sessions): refactor flows, fix grouping bugs and align validation fail text (#21379) chore(sessions): more driver tests (#21378) chore: rename domain_fn to origin_fn (#21413) chore: release 9.6.1 (#21404) fix: ensure that proxy logs are updated after the xhr has actually completed (#21373) chore: Re-organize tests in assertions_spec.js (#21283) chore: Distribute tests to desktop-gui containers. Make `desktop-gui` tests faster! (#21305) chore(sessions): add additional tests (#21338) fix: Allow submit button to be outside of the form for implicit submission (#21279) fix(launcher): support Firefox as a snap (#21328) chore(sessions): break out sessions manager code and add unit tests (#21268) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
XHR calls will now properly display the response body in the command log
Additional details
When the proxy gets the close event for the response, we send the
response:receivedevent to the client. There is a race condition where this might reach the client before the XHR readystate has been updated on the client. If this happens, the xhr that gets attached to the log will not have a response body yet. To fix this, we will listen to theonloadevent of the xhr call if the xhr call hasn't completed and delay updating the proxy logging response until then.How has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?