chore: cleanup dead code #21340
Merged
chore: cleanup dead code #21340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||
estrada9166
approved these changes
May 6, 2022
flotwig
approved these changes
May 6, 2022
| @@ -35,7 +35,7 @@ export class HtmlDataSource { | |||
| ) | |||
| } catch (e) { | |||
| err = e | |||
| await this.ctx.util.delayMs(1000) | |||
| await new Promise((resolve) => setTimeout(resolve, 1000)) | |||
There was a problem hiding this comment.
might be worth just using Bluebird.timeout here and elsewhere in this PR... so when we strip Bluebird out these timeouts are more easily discovered and replaced with a shared helper. Blue and I recently discussed this here: #21328 (comment)
There was a problem hiding this comment.
I don't think we use Bluebird at all in the data-context package currently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
N/A
Additional details
Removing some dead code that I came across while working on other tickets
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?