Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow submit button to be outside of the form for implicit submission #21279

Merged
merged 9 commits into from May 5, 2022
Merged

fix: Allow submit button to be outside of the form for implicit submission #21279

merged 9 commits into from May 5, 2022

Conversation

skvale
Copy link
Contributor

@skvale skvale commented Apr 30, 2022

User facing changelog

Submit buttons can be outside of the form for implicit submission

Additional details

Implicit submit wasn't working when the submit button wasn't nested within the form

How has the user experience changed?

Implicit submit with the enter key works when the submit button is outside of the form, but associated with a form attribute

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@skvale skvale requested a review from a team as a code owner April 30, 2022 15:18
@skvale skvale requested review from jennifer-shehane and removed request for a team April 30, 2022 15:18
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 30, 2022

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Apr 30, 2022

CLA assistant check
All committers have signed the CLA.

@skvale skvale changed the title feat: Allow submit button to be outside of the form feat: Allow submit button to be outside of the form for implicit submission Apr 30, 2022
@jennifer-shehane
Copy link
Member

@skvale Thanks for the contribution and for adding tests around the new behavior. Could you please sign our CLA? After that we’ll have someone from our team review as soon as possible.

@skvale skvale changed the title feat: Allow submit button to be outside of the form for implicit submission fix: Allow submit button to be outside of the form for implicit submission Apr 30, 2022
@jennifer-shehane jennifer-shehane removed their request for review May 2, 2022 14:09
@flotwig flotwig self-requested a review May 2, 2022 15:36
packages/driver/src/cy/commands/actions/type.ts Outdated Show resolved Hide resolved
packages/driver/src/cy/commands/actions/type.ts Outdated Show resolved Hide resolved
@marktnoonan marktnoonan self-assigned this May 4, 2022
@flotwig flotwig requested a review from marktnoonan May 4, 2022 00:16
Copy link
Contributor

@marktnoonan marktnoonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see this :)

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 9, 2022

Released in 9.6.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.6.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicit form submission should work when the submit button is not nested in the form, but is associated
6 participants