chore: [Multi-domain] Break out separate CI tasks to test the driver with experimentalSessionAndOrigin on #21148
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,5 @@ | |
| "retries": { | ||
| "runMode": 2, | ||
| "openMode": 0 | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| describe('stability', () => { | ||
| describe('before each transitions', () => { | ||
| describe('transitioning from a before block to an it block while unstable', () => { | ||
| beforeEach(() => { | ||
| cy.visit('/fixtures/auth/index.html') | ||
| cy.window().then((win) => { | ||
| win.location.href = 'http://localhost:3500/timeout?ms=1000' | ||
| }) | ||
| }) | ||
|
|
||
| it('fails if the page does not load within the page load timeout', { defaultCommandTimeout: 50, pageLoadTimeout: 500 }, (done) => { | ||
| cy.on('fail', (err) => { | ||
| expect(err.message).to.include(`Timed out after waiting \`500ms\` for your remote page to load.`) | ||
| done() | ||
| }) | ||
|
|
||
| cy.get('[data-cy="login-idp"]').click() // Takes you to idp.com | ||
| }) | ||
|
|
||
| it('waits for the page to load before running the command', { defaultCommandTimeout: 50 }, () => { | ||
| cy.get('body').invoke('text').should('equal', 'timeout') | ||
| }) | ||
|
|
||
| it('will retry and fail the command after the page loads', { defaultCommandTimeout: 50 }, (done) => { | ||
| cy.on('fail', (err) => { | ||
| expect(err.message).to.include(`Timed out retrying after 50ms: expected 'timeout' to equal 'not timeout'`) | ||
| done() | ||
| }) | ||
|
|
||
| cy.get('body').invoke('text').should('equal', 'not timeout') | ||
| }) | ||
| }) | ||
| }) | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,9 @@ | |
| "scripts": { | ||
| "clean-deps": "rm -rf node_modules", | ||
| "cypress:open": "node ../../scripts/cypress open", | ||
| "cypress:run": "node ../../scripts/cypress run --spec \"cypress/integration/*/*\",\"cypress/integration/*/!(multi-domain)/**/*\"", | ||
|
There was a problem hiding this comment. I had to do this in two passes. The first glob includes all test files at the level of the multi-domain folder, the second glob includes all tests files beyond the multi-domain folder but not including it. There was a problem hiding this comment. I think the serialization unit tests outside the |
||
| "cypress:open-experimentalSessionAndOrigin": "node ../../scripts/cypress open --config experimentalSessionAndOrigin=true", | ||
| "cypress:run-experimentalSessionAndOrigin": "node ../../scripts/cypress run --config experimentalSessionAndOrigin=true", | ||
| "postinstall": "patch-package", | ||
| "start": "node -e 'console.log(require(`chalk`).red(`\nError:\n\tRunning \\`yarn start\\` is no longer needed for driver/cypress tests.\n\tWe now automatically spawn the server in the pluginsFile.\n\tChanges to the server will be watched and reloaded automatically.`))'" | ||
| }, | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we bump this to 6 or 7 since so many tests for multi-domain since we were concerned with longer CI times?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to get a direct comparison but with current parallelization the CI job seems to run for roughly the same duration as our existing job. So I don't think we need to bump these right now.