Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Updates based on PR feedback #21137

Merged
merged 46 commits into from Apr 22, 2022
Merged

chore: Updates based on PR feedback #21137

merged 46 commits into from Apr 22, 2022

Commits on Apr 19, 2022

  1. add generic to cy.origin type

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    0c363df View commit details
    Browse the repository at this point in the history

  2. fix log type, update/add comments

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    76e5178 View commit details
    Browse the repository at this point in the history

  3. fix comment indentation

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    c486640 View commit details
    Browse the repository at this point in the history

  4. specific generic

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    2d756cf View commit details
    Browse the repository at this point in the history

  5. move RemoteState to internal types

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    7407dcb View commit details
    Browse the repository at this point in the history

  6. add on links to experimental flag descriptions

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    b23ddf4 View commit details
    Browse the repository at this point in the history

  7. chore: reduce nesting by flipping condition

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    985f5eb View commit details
    Browse the repository at this point in the history

  8. fix test title

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    6a421f3 View commit details
    Browse the repository at this point in the history

  9. simplify failing log

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    e043431 View commit details
    Browse the repository at this point in the history

  10. rename variable

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    7500d53 View commit details
    Browse the repository at this point in the history

  11. delete error property

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    43dfc2a View commit details
    Browse the repository at this point in the history

  12. fix types

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    856f1b7 View commit details
    Browse the repository at this point in the history

  13. fix type

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    ffaebd0 View commit details
    Browse the repository at this point in the history

  14. remove unnecessary todo

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    49f7b9c View commit details
    Browse the repository at this point in the history

  15. update wait test

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    2f1dfde View commit details
    Browse the repository at this point in the history

  16. jquery -> this

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    9a5aecb View commit details
    Browse the repository at this point in the history

  17. update comment

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    17ed708 View commit details
    Browse the repository at this point in the history

  18. remove vestigial autoRun

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    02a63ed View commit details
    Browse the repository at this point in the history

  19. use finally

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    348302a View commit details
    Browse the repository at this point in the history

  20. re-throw non-security errors

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    2f7d248 View commit details
    Browse the repository at this point in the history

  21. move back getting index

    @chrisbreiding
    chrisbreiding committed Apr 19, 2022
    Copy the full SHA
    5efb24a View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. add new state types

    @chrisbreiding
    chrisbreiding committed Apr 20, 2022
    Copy the full SHA
    6850b68 View commit details
    Browse the repository at this point in the history

  2. remove unnecessary export

    @chrisbreiding
    chrisbreiding committed Apr 20, 2022
    Copy the full SHA
    6c80197 View commit details
    Browse the repository at this point in the history

  3. startsWith -> includes

    @chrisbreiding
    chrisbreiding committed Apr 20, 2022
    Copy the full SHA
    10e87fb View commit details
    Browse the repository at this point in the history

  4. it -> them

    @chrisbreiding
    chrisbreiding committed Apr 20, 2022
    Copy the full SHA
    6c58d3d View commit details
    Browse the repository at this point in the history

  5. update system test

    @chrisbreiding
    chrisbreiding committed Apr 20, 2022
    Copy the full SHA
    992d629 View commit details
    Browse the repository at this point in the history

  6. remove use of promise constructor

    @chrisbreiding
    chrisbreiding committed Apr 20, 2022
    Copy the full SHA
    35ccc28 View commit details
    Browse the repository at this point in the history

  7. Revert "remove use of promise constructor" 

    This reverts commit 35ccc28.
    @chrisbreiding
    chrisbreiding committed Apr 20, 2022
    Copy the full SHA
    d96baa5 View commit details
    Browse the repository at this point in the history

  8. log errors from Page.getFrameTree

    @chrisbreiding
    chrisbreiding committed Apr 20, 2022
    Copy the full SHA
    11d6330 View commit details
    Browse the repository at this point in the history

  9. test if anything breaks when removing optional chaining operator

    @chrisbreiding
    chrisbreiding committed Apr 20, 2022
    Copy the full SHA
    ac1307f View commit details
    Browse the repository at this point in the history

  10. remove vestigial file

    @chrisbreiding
    chrisbreiding committed Apr 20, 2022
    Copy the full SHA
    9e3750b View commit details
    Browse the repository at this point in the history

  11. handle queue ending in cross-origin driver

    @chrisbreiding
    chrisbreiding committed Apr 20, 2022
    Copy the full SHA
    f19402c View commit details
    Browse the repository at this point in the history

  12. fix coordinates spec

    @chrisbreiding
    chrisbreiding committed Apr 20, 2022
    Copy the full SHA
    1f43423 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. improve chrome/firefox check in extension

    @chrisbreiding
    chrisbreiding committed Apr 21, 2022
    Copy the full SHA
    9cd2490 View commit details
    Browse the repository at this point in the history

  2. improve secure cookie regex

    @chrisbreiding
    chrisbreiding committed Apr 21, 2022
    Copy the full SHA
    1a2167d View commit details
    Browse the repository at this point in the history

  3. use production mode for cross-origin driver bundle

    @chrisbreiding
    chrisbreiding committed Apr 21, 2022
    Copy the full SHA
    ebd40c7 View commit details
    Browse the repository at this point in the history

  4. adding remoteStates.getPrimary

    @mschile
    mschile committed Apr 21, 2022
    Copy the full SHA
    7c8d698 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2022

  1. catch and ignore queue errors

    @chrisbreiding
    chrisbreiding committed Apr 22, 2022
    Copy the full SHA
    890b827 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'md-pr-feedback' of github.com:cypress-io/cypress into m… 

    …d-pr-feedback
    @chrisbreiding
    chrisbreiding committed Apr 22, 2022
    Copy the full SHA
    054680c View commit details
    Browse the repository at this point in the history

  3. remove optional chaining in postMessage handler

    @chrisbreiding
    chrisbreiding committed Apr 22, 2022
    Copy the full SHA
    2ae28a0 View commit details
    Browse the repository at this point in the history

  4. removed unnecessary async

    @chrisbreiding
    chrisbreiding committed Apr 22, 2022
    Copy the full SHA
    793cac1 View commit details
    Browse the repository at this point in the history

  5. update frame tree on cri client reconnect

    @chrisbreiding
    chrisbreiding committed Apr 22, 2022
    Copy the full SHA
    02f7fd8 View commit details
    Browse the repository at this point in the history

  6. fix formatting

    @chrisbreiding
    chrisbreiding committed Apr 22, 2022
    Copy the full SHA
    0569c91 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'feature-multidomain' into md-pr-feedback

    @chrisbreiding
    chrisbreiding committed Apr 22, 2022
    Copy the full SHA
    5e71789 View commit details
    Browse the repository at this point in the history

  8. renaming remoteStates variable

    @mschile
    mschile committed Apr 22, 2022
    Copy the full SHA
    6ee45ac View commit details
    Browse the repository at this point in the history

  9. prevent requests from being paused if experimentalSessionAndOrigin fl… 

    …ag is off
    @chrisbreiding
    chrisbreiding committed Apr 22, 2022
    Copy the full SHA
    fde3acf View commit details
    Browse the repository at this point in the history