Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Bumping electron dependency to 15.5.1 #21072

Merged
merged 4 commits into from Apr 14, 2022
Merged

chore(deps): Bumping electron dependency to 15.5.1 #21072

merged 4 commits into from Apr 14, 2022

Conversation

tbiethman
Copy link
Contributor

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

  • [n/a] Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [n/a] Has a PR for user-facing changes been opened in cypress-documentation?
  • [n/a] Have API changes been updated in the type definitions?
  • [n/a] Have new configuration options been added to the cypress.schema.json?

@tbiethman tbiethman requested a review from a team as a code owner April 13, 2022 18:54
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 13, 2022

Thanks for taking the time to open a PR!

@tbiethman tbiethman requested review from jennifer-shehane and removed request for a team April 13, 2022 18:54
@tbiethman
Copy link
Contributor Author

tbiethman commented Apr 13, 2022 •
edited

The Percy diff is interesting. The baseline image does not show the "You can change this key in the Dashboard" link, new image does. The link should always be rendered, there's no logic around its presentation. You can also see it in this image from the baseline that didn't change. So it seems like there's some level of flake there, maybe due to the icon loading within the link?

Edit: Yeah the previous snapshots must have been taken mid-transition as the 'Record Key' section is opening. That specific test was not waiting for open animations to finish, whereas the rest in the file were. I'll update the spec here to guarantee consistent output going forward.

@cypress
Copy link

cypress bot commented Apr 13, 2022 •
edited


Test summary

19391 • 0 • 218 • 0 • Flakiness 1

Run details
Project cypress
Status Passed
Commit 92e586a
Started Apr 14, 2022 5:38 PM
Ended Apr 14, 2022 5:49 PM
Duration 11:42 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️

Flakiness

cypress/integration/cypress/proxy-logging_spec.ts 1 Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig self-requested a review April 14, 2022 15:37
@jennifer-shehane jennifer-shehane removed their request for review April 14, 2022 16:14
@tbiethman tbiethman merged commit 71a18e4 into develop Apr 14, 2022
@tbiethman tbiethman deleted the tbiethman/chore/issue-21068-electron-bump branch April 14, 2022 18:42
@cypress-bot cypress-bot bot mentioned this pull request Apr 14, 2022
Closed
tbiethman added a commit that referenced this pull request Apr 15, 2022
@tbiethman
Revert "chore(deps): Bumping electron dependency to 15.5.1 (#21072)"
02d26a7 
This reverts commit 71a18e4.
tgriesser added a commit that referenced this pull request Apr 20, 2022
@tgriesser
Merge branch '10.0-release' into tgriesser/chore/UNIFY-1256-auto-merg…
e1a4b3d 
…e-config

* 10.0-release:
  fix: make error on integration folder point to e2e (#20853)
  fix(unify): Update Cypress Dashboard Service Link in Login Modal (#21084)
  chore: fix windows node_modules install step (#21098)
  fix: webpack integration tests for app w webpack-dev-server-fresh (#21093)
  fix: move non spec files on migration (#21054)
  Bumping electron version in root
  chore(deps): Bumping electron dependency to 15.5.1 (#21072)
  fix: resolves correctly specPattern (#21057)
  feat: replace reconfigure button on settings page with link to config doc (#21077)
  feat(launchpad): update CT setup and config scaffolding (#20893)
  fix: cy.type('{enter}') on <input> elements submits the form correctly after Firefox 98. (#21042)
  chore: making the npm deps for vue, react, and vue2 use 0.0.0-dev (#21081)
  fix(cli): show additional mitigation steps for max path length error (#21047)
  fix: Plugin error when sending on disconnected IPC channel (#21011)
  chore: add internal types for cy.session command (#21028)
  chore: Update Chrome (stable) to 100.0.4896.88 (#21043)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flotwig flotwig flotwig approved these changes

@mjhenkes mjhenkes mjhenkes approved these changes

@davidmunechika davidmunechika davidmunechika approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update electron dependency to 15.5.1
4 participants
@tbiethman @flotwig @mjhenkes @davidmunechika