-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support escaped dollar sign in CYPRESS_DOWNLOAD_PATH_TEMPLATE #20698
Merged
mjhenkes
merged 7 commits into
cypress-io:develop
from
amoshydra:feat/support-escaped-dollar-sign-in-cypress-download-path-template
Mar 24, 2022
Merged
feat: support escaped dollar sign in CYPRESS_DOWNLOAD_PATH_TEMPLATE #20698
mjhenkes
merged 7 commits into
cypress-io:develop
from
amoshydra:feat/support-escaped-dollar-sign-in-cypress-download-path-template
Mar 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoshydra
requested review from
jennifer-shehane
and removed request for
a team
March 19, 2022 03:27
Thanks for taking the time to open a PR!
|
amoshydra
changed the title
Support escaped dollar sign in CYPRESS_DOWNLOAD_PATH_TEMPLATE
feat: support escaped dollar sign in CYPRESS_DOWNLOAD_PATH_TEMPLATE
Mar 19, 2022
This was referenced Mar 19, 2022
…ss-download-path-template
mjhenkes
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thank you for the PR and the detailed investigation!
emilyrohrbough
approved these changes
Mar 23, 2022
…ss-download-path-template
…ss-download-path-template
…ss-download-path-template
amoshydra
deleted the
feat/support-escaped-dollar-sign-in-cypress-download-path-template
branch
March 27, 2022 10:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Support escaped dollar sign in CYPRESS_DOWNLOAD_PATH_TEMPLATE
Additional details
Related:
To support usage of
CYPRESS_DOWNLOAD_PATH_TEMPLATE
in npmrc in npm@6How has the user experience changed?
User will be able to use one of these in npmrc in npm@6
PR Tasks
cypress-documentation
? docs: add usage of CYPRESS_DOWNLOAD_PATH_TEMPLATE in npmrc cypress-documentation#4397type definitions
?cypress.schema.json
?