fix: types for Cypress.Commands.add (#20376) #20377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atarek12
requested review from
jennifer-shehane
and removed request for
a team
|
Thanks for taking the time to open a PR!
|
|
|
atarek12
changed the title
atarek12
force-pushed
the
fix-prevSubject-types
branch
2 times, most recently
from
97456df
to
87091cd
Compare
atarek12
force-pushed
the
fix-prevSubject-types
branch
from
87091cd
to
f6e6edd
Compare
|
@atarek12 Thanks for opening this PR. Our team will pick this up as soon as possible. |
emilyrohrbough
requested changes
Apr 4, 2022
emilyrohrbough
approved these changes
Apr 12, 2022
BlueWinds
approved these changes
Apr 12, 2022
|
@atarek12 This PR caused a type failure when merged in and was reverted, can you please re-open this PR against the latest |
tbiethman
added a commit
that referenced
this pull request
Apr 15, 2022
tgriesser
added a commit
that referenced
this pull request
Apr 20, 2022
…e-config * 10.0-release: chore: Move component-index generation to scaffold-config package (#21090) fix: label text should be clickable to toggle snapshot highlight (#21122) feat: add next preset to webpack-dev-server-fresh (#21069) chore: add dev-servers as deps to server to be included in the binary (#21142) fix: do not highlight preExtension if selected option is renameFolder (#21121) fix(unify): Remove 'Reconfigure' dropdown from Testing Type chooser (#21063) feat(unify): launchpad header breadcrumbs and reusable tooltip component (#20648) test: add windows-test-kitchensink job (#20847) fix: aut centering and height calculation (#21019) chore: fix tests that fail on windows (#21055) fix: running a new test after already having run tests (#21087) fix: ct project setup framework keys for next and nuxt (#21116) fix: remove MountReturn from scaffolded ct support file (#21119) fix: do not scaffold fixtures if folder exist (#21078) fix: revert "fix: types for Cypress.Commands.add (#20376)" (#21104) chore: Update Chrome (stable) to 100.0.4896.127 and Chrome (beta) to 101.0.4951.34 (#21083) fix: types for Cypress.Commands.add (#20376) (#20377)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Fix
Cypress.Command.add()TypeScript types. Fixes #20376elementwhile usingprevSubject: trueoptionselectorto the subject while usingprevSubject: true | "element"optionAdditional details
This change fixes typescript errors while using the
Cypress.Command.add()with { prevSubject: true } or { prevSubject: "element" }How has the user experience changed?
No typescript error while trying to access the selector.
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?