Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add CYPRESS_VERIFY_TIMEOUT param and a test for it #19282

Merged
merged 10 commits into from
Dec 20, 2021
Merged

fix: add CYPRESS_VERIFY_TIMEOUT param and a test for it #19282

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2c5ea53
add CYPRESS_VERIFY_TIMEOUT param and a test for it
legap Dec 6, 2021
0137a95
Merge branch 'develop' into issue-18290-add-configurable-verify-timeout
legap Dec 6, 2021
a5b2d3e
Merge branch 'develop' into issue-18290-add-configurable-verify-timeout
legap Dec 8, 2021
09f9eb3
Merge branch 'develop' into issue-18290-add-configurable-verify-timeout
legap Dec 9, 2021
21d55ef
Merge branch 'develop' into issue-18290-add-configurable-verify-timeout
mjhenkes Dec 14, 2021
a32ed21
Merge branch 'develop' into issue-18290-add-configurable-verify-timeout
legap Dec 15, 2021
045bea1
Merge branch 'develop' into issue-18290-add-configurable-verify-timeout
mjhenkes Dec 16, 2021
408cef1
Merge branch 'develop' into issue-18290-add-configurable-verify-timeout
legap Dec 16, 2021
8975869
Merge branch 'develop' into issue-18290-add-configurable-verify-timeout
legap Dec 17, 2021
52aa4ea
Merge branch 'develop' into issue-18290-add-configurable-verify-timeout
emilyrohrbough Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/lib/tasks/verify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const logger = require('../logger')
const xvfb = require('../exec/xvfb')
const state = require('./state')

const VERIFY_TEST_RUNNER_TIMEOUT_MS = 30000
const VERIFY_TEST_RUNNER_TIMEOUT_MS = process.env.CYPRESS_VERIFY_TIMEOUT || 30000

const checkExecutable = (binaryDir) => {
const executable = state.getPathToExecutable(binaryDir)
Expand Down
8 changes: 8 additions & 0 deletions cli/test/lib/tasks/verify_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,14 @@ context('lib/tasks/verify', () => {
expect(verify.VERIFY_TEST_RUNNER_TIMEOUT_MS).to.be.gt(10000)
})

it('accepts custom verify task timeout', () => {
process.env.CYPRESS_VERIFY_TIMEOUT = '500000'
delete require.cache[require.resolve(`${lib}/tasks/verify`)]
const newVerifyInstance = require(`${lib}/tasks/verify`)

expect(newVerifyInstance.VERIFY_TEST_RUNNER_TIMEOUT_MS).to.be.gte(500000)
})

it('logs error and exits when no version of Cypress is installed', () => {
return verify
.start()
Expand Down