-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(driver): fix integration test retry configuration #18643
Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
d243a15
test(driver): fix integration test retry configuration
emilyrohrbough 973f354
add assetions
emilyrohrbough f24ec80
Merge branch 'develop' into fix-driver-retries
emilyrohrbough 66c2fd8
move debug code to running test.
emilyrohrbough 2eb8ef1
Merge branch 'develop' into fix-driver-retries
emilyrohrbough e1cdde4
Merge branch 'develop' into fix-driver-retries
emilyrohrbough 891567a
pr feedback
emilyrohrbough 15ffd2f
add log context when failures occur
emilyrohrbough f741ecb
revert change
emilyrohrbough 55e70e1
.
emilyrohrbough f987fac
try increasing retry just to see
emilyrohrbough 14cc8a6
Update navigation_spec.js
emilyrohrbough f6bb5df
fix this test
emilyrohrbough 358b844
for fun, lets try these flaky tests
emilyrohrbough 717c8dc
Merge branch 'develop' into fix-driver-retries
emilyrohrbough 5edf0ee
Update navigation_spec.js
emilyrohrbough e89ab54
lint
emilyrohrbough a9d0d81
lint
emilyrohrbough 37b8892
Merge branch 'develop' into fix-driver-retries
emilyrohrbough 952dda3
Merge branch 'develop' into fix-driver-retries
emilyrohrbough c1f9ae1
Merge branch 'develop' into fix-driver-retries
emilyrohrbough 6c25eb5
Apply suggestions from code review
emilyrohrbough e19d176
don't timeout passing tests
flotwig 11f5c14
Merge branch 'develop' into fix-driver-retries
emilyrohrbough File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For anyone curious to reproduce this issue, you can comment this out and runt his test to consistently see the error shown in the video Zach linked: