fix: The content of <script> and <style> inside <body> should be ignored with cy.contains.
#17477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
sainthkh
commented
Jul 26, 2021
| cy.contains('some-script-content').should('not.match', 'script') | ||
| cy.contains('some-script-content').should('not.exist') |
There was a problem hiding this comment.
This code was added at #5079. It had to be written in this way because cy.contains() returns <body> tag at that time.
It is changed, because it simply fails.
sainthkh
requested review from
chrisbreiding and
jennifer-shehane
and removed request for
a team
jennifer-shehane
added
the
type: breaking change
|
Updated base branch to 9.0-release branch |
|
Thanks @sainthkh, we're prioritizing reviewing other work for now for the immediate release but do plan to review this when we can. |
- moves removing style and script elements into own function, since it's not related to normalizing whitespace - adds nested style and script elements to html fixture. this fails the test with the previous implementation, which only removed non-nested ones - uses jquery for removing elements, which will remove nested style and script elements as well as non-nested ones
chrisbreiding
approved these changes
Aug 4, 2021
7 tasks
|
Thanks everyone for making this change, it is very much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
cy.contains()no longer yields the<body>element when it matches the content of<script>or<style>tags.Additional details
<script>or<style>tag inside the<body>bodytag,<script>and<style>tags inside it will be removedHow has the user experience changed?
N/A
Notes
includeScriptContent,includeStyleContent, do we?PR Tasks