Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set the value of testingType in project-ct #16885

Merged
merged 2 commits into from
Jun 10, 2021
Merged

fix: set the value of testingType in project-ct #16885

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56728c6
fix: set the value of testingType in project-ct
elevatebart Jun 9, 2021
f41c8b6
style: add comment about changes
elevatebart Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/server-ct/src/project-ct.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,13 @@ export class ProjectCt extends ProjectBase<ServerCt> {

updatedConfig.componentTesting = true
elevatebart marked this conversation as resolved.
Show resolved Hide resolved

// This value is normally set up in the `packages/server/lib/plugins/index.js#110`
// But if we don't return it in the plugins function, it never gets set
// Since there is no chance that it will have any other value here, we set it to "component"
// This allows users to not return config in the `cypress/plugins/index.js` file
// https://github.com/cypress-io/cypress/issues/16860
updatedConfig.resolved.testingType = { value: 'component' }

debug('updated config: %o', updatedConfig)

return updatedConfig
Expand Down