Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server-ct): support exclusive inline config #16468

Merged
merged 7 commits into from
May 13, 2021

Conversation

lmiller1990
Copy link
Contributor

@lmiller1990 lmiller1990 commented May 12, 2021

User facing changelog

Correctly use componentFolder and testFiles values from returned from plugins in component testing runner.

I added a test project, but this does not run on CI. It will once #16354 is merged.

I tested in manually by doing cd packages/server-ct/test/fixtures/projects/inline-config-only and running yarn cy:open. It found the component and spec files correctly.

Additional details

We were the resolved values for testFiles and componentFolder as specified in cypress.json. If you specified different values in the config returned from plugins, they were not used. We should be using the resolved values.

How has the user experience changed?

Allow customizing testFiles and componentFolder by returning a config object in plugins.

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 12, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented May 12, 2021



Test summary

460 0 6 0Flakiness 0


Run details

Project cypress
Status Passed
Commit 8298361
Started May 12, 2021 6:44 AM
Ended May 12, 2021 6:53 AM
Duration 09:24 💡
OS Linux Debian - 10.8
Browser Electron 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990 lmiller1990 changed the title fix(server): WIP: support exclusive inline config fix(server-ct): support exclusive inline config May 12, 2021
@lmiller1990 lmiller1990 marked this pull request as ready for review May 12, 2021 05:28
Copy link
Contributor

@agg23 agg23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we deprecating componentFolder? Seems like we should do that soon, rather than fixing bugs with it

@lmiller1990
Copy link
Contributor Author

lmiller1990 commented May 13, 2021

I think we are @agg23, but what will take it's place when when is not clear. Since it could be months before it is deprecated, this fix is worth having - especially considering it's a breaking change (this was working pre 7.0).

testFiles is not going away, that will stick around (was also broken as part of the original issue, another regression).

@lmiller1990 lmiller1990 merged commit 4592df2 into develop May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component testing does not honour configuration values provided by plugins.
2 participants