Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@cypress/webpack-batteries-included-preprocessor): Ensure typescript options are set if typescript path is provided #15967

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Apr 13, 2021

User Facing Changelog

N/A - this only affects the @cypress/webpack-batteries-included-preprocessor package

Details

  • Fixes an issue with @cypress/webpack-batteries-included-preprocessor where passing in webpackOptions (namely via the defaultOptions) and the typescript path would not added the needed typescript-related webpack options.
  • Updates the README to note that passing in the typescript path is necessary to enable TypeScript support

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 13, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Apr 13, 2021



Test summary

200 0 1 0Flakiness 0


Run details

Project cypress
Status Passed
Commit 0788219
Started Apr 13, 2021 9:35 PM
Ended Apr 13, 2021 9:43 PM
Duration 08:17 💡
OS Linux Debian - 10.8
Browser Chrome 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@chrisbreiding chrisbreiding changed the title fix(@cypress/webpack-batteries-included-preprocesssor): Ensure typescript options are set if typescript path is provided fix(@cypress/webpack-batteries-included-preprocessor): Ensure typescript options are set if typescript path is provided Apr 14, 2021
@chrisbreiding chrisbreiding changed the base branch from develop to master April 14, 2021 17:15
@chrisbreiding chrisbreiding requested a review from a team as a code owner April 14, 2021 17:15
@chrisbreiding chrisbreiding requested review from jennifer-shehane and removed request for a team April 14, 2021 17:15
@chrisbreiding chrisbreiding changed the base branch from master to develop April 14, 2021 17:15
@chrisbreiding
Copy link
Contributor Author

Closing in favor of #15991, so it's against master

@chrisbreiding chrisbreiding deleted the issue-15767-webpack-typescript-readme-improvement branch April 5, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't run Typescript tests in Cypress when I have @cypress/webpack-batteries-included-preprocessor enabled
1 participant