fix: cy.contains does not return <body> when the finding text is in <script> or <style> #15574

sainthkh · 2021-03-19T03:58:57Z

Closes cy.contains('xxx').should('not.exist') try to expect <body> not to exist in the DOM #14861

User facing changelog

cy.contains does not return <body> when the finding text is in <script> or <style>.

Additional details

Why was this change necessary? => cy.contains should return "element not found" even if the finding text is in <script> or <style> tags.
What is affected by this change? => Please check the note "Is this a breaking change?" below.
Any implementation details to explain? => Added "body" to the ":not" list.

Is this a breaking change?

In some tests like below,

cypress/packages/driver/cypress/integration/commands/querying_spec.js

Lines 1573 to 1577 in 8286fcd

    
           it('will not find script elements', () => { 
        
             cy.$$('<script>// some-script-content </script>').appendTo(cy.$$('body')) 
        
             cy.contains('some-script-content').should('not.match', 'script') 
        
           })

the test fails after this change, because cy.contains() does not return any element.

Should we call this behavior a bug or a breaking change?

How has the user experience changed?

N/A

PR Tasks

Have tests been added/updated?

cypress-bot · 2021-03-19T03:58:59Z

Thanks for taking the time to open a PR!

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

Fix

3ed3e9a

sainthkh closed this Mar 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: cy.contains does not return <body> when the finding text is in <script> or <style> #15574

fix: cy.contains does not return <body> when the finding text is in <script> or <style> #15574

sainthkh commented Mar 19, 2021 •

edited

cypress-bot bot commented Mar 19, 2021

	it('will not find script elements', () => {
	cy.$$('<script>// some-script-content </script>').appendTo(cy.$$('body'))

	cy.contains('some-script-content').should('not.match', 'script')
	})

fix: cy.contains does not return <body> when the finding text is in <script> or <style> #15574

fix: cy.contains does not return <body> when the finding text is in <script> or <style> #15574

Conversation

sainthkh commented Mar 19, 2021 • edited

User facing changelog

Additional details

Is this a breaking change?

How has the user experience changed?

PR Tasks

cypress-bot bot commented Mar 19, 2021

sainthkh commented Mar 19, 2021 •

edited