Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use app.whenReady and remove delay race for electron startup #15075

Merged
merged 5 commits into from Feb 15, 2021
Merged

fix: use app.whenReady and remove delay race for electron startup #15075

merged 5 commits into from Feb 15, 2021

Commits on Feb 12, 2021

  1. init: fixed startup delay issue 

    This change fixes an issue that caused the startup to be delayed by 500ms.
We used `app.on('ready')` without checking `app.isReady()`, however the
'ready' event may already have fired at this point and thus we never
resolved the Promise waiting for it.
Using `app.whenReady` fixes this and now that Promise resolves before
the delay expires.

Related links:

https://www.electronjs.org/docs/api/app#event-ready
https://www.electronjs.org/docs/api/app#appwhenready
    @thlorenz @flotwig
    thlorenz authored and flotwig committed Feb 12, 2021
    Copy the full SHA
    bf22e30 View commit details
    Browse the repository at this point in the history

  2. skip the promise.delay

    @flotwig
    flotwig committed Feb 12, 2021
    Copy the full SHA
    86d5406 View commit details
    Browse the repository at this point in the history

  3. fix unit/integration specs

    @flotwig
    flotwig committed Feb 12, 2021
    Copy the full SHA
    5533bbb View commit details
    Browse the repository at this point in the history

  4. same for run + open-ct

    @flotwig
    flotwig committed Feb 12, 2021
    Copy the full SHA
    3c46bb8 View commit details
    Browse the repository at this point in the history

  5. snapshots and mocks

    @flotwig
    flotwig committed Feb 12, 2021
    Copy the full SHA
    7d66091 View commit details
    Browse the repository at this point in the history