Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Electron open links no longer crashes w/ error - Cannot read 'show' of undefined #14914

Merged
merged 3 commits into from Feb 9, 2021

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Feb 4, 2021

User facing changelog

  • Fixed a regression introduced in 6.4.0 that caused Electron to crash when opening outside links in the Command Log.

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 4, 2021

Thanks for taking the time to open a PR!

@jennifer-shehane jennifer-shehane changed the title Pass automation to _launch function as expected fix: Electron open links no longer throws error - Cannot read 'show' of undefined Feb 4, 2021
@jennifer-shehane jennifer-shehane changed the title fix: Electron open links no longer throws error - Cannot read 'show' of undefined fix: Electron open links no longer crashes w/ error - Cannot read 'show' of undefined Feb 4, 2021
@cypress
Copy link

cypress bot commented Feb 4, 2021



Test summary

9314 0 118 3Flakiness 1


Run details

Project cypress
Status Passed
Commit d093f33
Started Feb 9, 2021 3:04 AM
Ended Feb 9, 2021 3:16 AM
Duration 12:19 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'show' of undefined when opening links in Command Log in Electron
2 participants