fix: Modify doubleEscape to handle path with extra backslashes and launch edge without browser key #14723
Conversation
|
Thanks for taking the time to open a PR!
|
|
|
|
Can someone please review this PR? |
|
@SagarGaniga The server-e2e-tests-chrome failing are unrelated to this PR. A recent change in our stdout warnings is causing some flake in our internal snapshots. Our team is hoping to review this PR next sprint. |
| if (pathStr.indexOf('chrome.exe') > -1) { | ||
| return { path, browserKey: 'chrome' } | ||
| } | ||
|
|
||
| if (pathStr.indexOf('edge.exe') > -1) { | ||
| return { path, browserKey: 'edge' } |
There was a problem hiding this comment.
Ha, I guess this does technically work for msedge.exe too
There was a problem hiding this comment.
Yeah, keeping that browserKey edge for msedge.exe too as we use edge everywhere else.
| expect(res.browserKey).to.eq('chrome') | ||
| }) | ||
|
|
||
| it('returns path and edge given just path', () => { |
There was a problem hiding this comment.
Could also use a test for msedge.exe - that is what #14716 is about
| function doubleEscape (s: string) { | ||
| return win32.join(...s.split(win32.sep)).replace(/\\/g, '\\\\') | ||
| } | ||
|
|
There was a problem hiding this comment.
could you just import this from windows.ts?
There was a problem hiding this comment.
I think you mean packages/launcher/lib/windows/index.ts
Exported that function, used it in the test case and added its own test cases
|
While testing this PR, I noticed that the errors for path detection here are kinda abysmal... no fault of this PR tho this PR
develop
|
User facing changelog
--browserfor edge browsers on windows, allows users to pass just path to edge.exe and launch the browser.--browserto launch browsers when the path has extra backslashes on windowsAdditional details
--browserwas breaking on windows for every browser but it was fixed in v5.4.0. But it still has issuesThis PR adds code to handle edge paths and modifies
doubleEscapefunction with the help ofpath.win32module which is capable of handling windows specific path separators inwindows/index.tsThis PR also adds some test cases to make sure these use cases are always tested.
How has the user experience changed?
Users can pass edge and chrome paths with more freedom around escaped chars.
Users can now
cypress run --browser "C:\\foo\\bar\\edge.exe"cypress run --browser "C:\\\\foo\\\\bar\\\\chrome.exe"PR Tasks